Re: [PATCH RFC net-next 3/4] net: mvneta: convert to phylink EEE implementation

[Simon Horman <simon.horman@corigine.com>]

On Fri, Jun 09, 2023 at 10:11:26AM +0100, Russell King (Oracle) wrote:
> Convert mvneta to use phylink's EEE implementation, which means we just
> need to implement the two methods for LPI control, and adding the
> initial configuration.
> 
> Disabling LPI requires clearing a single bit. Enabling LPI needs a full
> configuration of several values, as the timer values are dependent on
> the MAC operating speed.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/net/ethernet/marvell/mvneta.c | 95 +++++++++++++++++----------
>  1 file changed, 61 insertions(+), 34 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index e2abc00d0472..c634ec5d3f9a 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -284,8 +284,10 @@
>  					  MVNETA_TXQ_BUCKET_REFILL_PERIOD))
>  
>  #define MVNETA_LPI_CTRL_0                        0x2cc0
> +#define      MVNETA_LPI_CTRL_0_TS                0xff << 8

Hi Russell,

maybe GENMASK would be useful here. If not, perhaps (0xffUL << 8)

>  #define MVNETA_LPI_CTRL_1                        0x2cc4
>  #define      MVNETA_LPI_REQUEST_ENABLE           BIT(0)
> +#define      MVNETA_LPI_CTRL_1_TW                0xfff << 4

Likewise here.

>  #define MVNETA_LPI_CTRL_2                        0x2cc8
>  #define MVNETA_LPI_STATUS                        0x2ccc
>  
> @@ -541,10 +543,6 @@ struct mvneta_port {
>  	struct mvneta_bm_pool *pool_short;
>  	int bm_win_id;
>  
> -	bool eee_enabled;
> -	bool eee_active;
> -	bool tx_lpi_enabled;
> -
>  	u64 ethtool_stats[ARRAY_SIZE(mvneta_statistics)];
>  
>  	u32 indir[MVNETA_RSS_LU_TABLE_SIZE];
> @@ -4232,9 +4230,6 @@ static void mvneta_mac_link_down(struct phylink_config *config,
>  		val |= MVNETA_GMAC_FORCE_LINK_DOWN;
>  		mvreg_write(pp, MVNETA_GMAC_AUTONEG_CONFIG, val);
>  	}
> -
> -	pp->eee_active = false;
> -	mvneta_set_eee(pp, false);
>  }

mvneta_set_eee() seems unused after this patch.
Perhaps it can be removed?

...