netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: mlxsw: i2c: Switch back to use struct i2c_driver's .probe()
@ 2023-06-12  7:22 Uwe Kleine-König
  2023-06-12  8:20 ` Ido Schimmel
  2023-06-12 11:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2023-06-12  7:22 UTC (permalink / raw)
  To: Ido Schimmel, Petr Machata, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni
  Cc: netdev, kernel

After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
call-back type"), all drivers being converted to .probe_new() and then
commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
convert back to (the new) .probe() to be able to eventually drop
.probe_new() from struct i2c_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/net/ethernet/mellanox/mlxsw/i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/i2c.c b/drivers/net/ethernet/mellanox/mlxsw/i2c.c
index 2c586c2308ae..41298835a11e 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/i2c.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/i2c.c
@@ -751,7 +751,7 @@ static void mlxsw_i2c_remove(struct i2c_client *client)
 
 int mlxsw_i2c_driver_register(struct i2c_driver *i2c_driver)
 {
-	i2c_driver->probe_new = mlxsw_i2c_probe;
+	i2c_driver->probe = mlxsw_i2c_probe;
 	i2c_driver->remove = mlxsw_i2c_remove;
 	return i2c_add_driver(i2c_driver);
 }

base-commit: ac9a78681b921877518763ba0e89202254349d1b
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: mlxsw: i2c: Switch back to use struct i2c_driver's .probe()
  2023-06-12  7:22 [PATCH] net: mlxsw: i2c: Switch back to use struct i2c_driver's .probe() Uwe Kleine-König
@ 2023-06-12  8:20 ` Ido Schimmel
  2023-06-12  9:50   ` Uwe Kleine-König
  2023-06-12 11:00 ` patchwork-bot+netdevbpf
  1 sibling, 1 reply; 4+ messages in thread
From: Ido Schimmel @ 2023-06-12  8:20 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Petr Machata, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, netdev, kernel, vadimp

On Mon, Jun 12, 2023 at 09:22:22AM +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>

I assume it's intended for net-next.

> ---
>  drivers/net/ethernet/mellanox/mlxsw/i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/i2c.c b/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> index 2c586c2308ae..41298835a11e 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/i2c.c
> @@ -751,7 +751,7 @@ static void mlxsw_i2c_remove(struct i2c_client *client)
>  
>  int mlxsw_i2c_driver_register(struct i2c_driver *i2c_driver)
>  {
> -	i2c_driver->probe_new = mlxsw_i2c_probe;
> +	i2c_driver->probe = mlxsw_i2c_probe;
>  	i2c_driver->remove = mlxsw_i2c_remove;
>  	return i2c_add_driver(i2c_driver);
>  }
> 
> base-commit: ac9a78681b921877518763ba0e89202254349d1b
> -- 
> 2.39.2
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: mlxsw: i2c: Switch back to use struct i2c_driver's .probe()
  2023-06-12  8:20 ` Ido Schimmel
@ 2023-06-12  9:50   ` Uwe Kleine-König
  0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2023-06-12  9:50 UTC (permalink / raw)
  To: Ido Schimmel
  Cc: Petr Machata, vadimp, netdev, Eric Dumazet, kernel,
	Jakub Kicinski, Paolo Abeni, David S. Miller

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

On Mon, Jun 12, 2023 at 11:20:31AM +0300, Ido Schimmel wrote:
> On Mon, Jun 12, 2023 at 09:22:22AM +0200, Uwe Kleine-König wrote:
> > After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> > call-back type"), all drivers being converted to .probe_new() and then
> > commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> > convert back to (the new) .probe() to be able to eventually drop
> > .probe_new() from struct i2c_driver.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> Tested-by: Ido Schimmel <idosch@nvidia.com>
> 
> I assume it's intended for net-next.

Indeed, forget the subject-prefix, sorry.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: mlxsw: i2c: Switch back to use struct i2c_driver's .probe()
  2023-06-12  7:22 [PATCH] net: mlxsw: i2c: Switch back to use struct i2c_driver's .probe() Uwe Kleine-König
  2023-06-12  8:20 ` Ido Schimmel
@ 2023-06-12 11:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-12 11:00 UTC (permalink / raw)
  To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E?=
  Cc: idosch, petrm, davem, edumazet, kuba, pabeni, netdev, kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 12 Jun 2023 09:22:22 +0200 you wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> commit 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> [...]

Here is the summary with links:
  - net: mlxsw: i2c: Switch back to use struct i2c_driver's .probe()
    https://git.kernel.org/netdev/net-next/c/3a2cb45ca0cc

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-06-12 11:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-12  7:22 [PATCH] net: mlxsw: i2c: Switch back to use struct i2c_driver's .probe() Uwe Kleine-König
2023-06-12  8:20 ` Ido Schimmel
2023-06-12  9:50   ` Uwe Kleine-König
2023-06-12 11:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).