From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B026C8C1 for ; Mon, 12 Jun 2023 21:14:36 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A5321BF1; Mon, 12 Jun 2023 14:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xwwebQPgbNOKpFrm5K41615nrmEyOJejBS23JzW+wa4=; b=P9gF7R78DXM9CvUbX2txIGJInw f/GSSTc9Zc+TCjTFpsVCR9o0N7QafjmgU88Zb/MoCLk+RI0zbWWZ6F09YaPbvuBsMcBYzw1mOmZ9e 9jBXXYG7+oJjYBsHPzmw/RQh9zeS9k+MYyOBe3GNkx/MX68Hus+lIYaqCbtWCbl4HLnV7j4OmJKJO Ua7b0draa/WshwtQHsqbP/vvSOCevxos0ct46UF7/Af7jWWB18gZva4setkjZUw1OIAMHqj4S42Ge C5Eo1IU5D1LInVm/2MVeY5jtkilwzuDCSpyydyU0MO8zCGOZdsZFFv0THIB1J11IE91g081djlcNY UlV5dR9w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41672) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q8ora-0006Pm-S5; Mon, 12 Jun 2023 22:14:10 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q8orZ-0005KR-PL; Mon, 12 Jun 2023 22:14:09 +0100 Date: Mon, 12 Jun 2023 22:14:09 +0100 From: "Russell King (Oracle)" To: arinc9.unal@gmail.com Cc: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net v4 3/7] net: dsa: mt7530: fix trapping frames on non-MT7621 SoC MT7530 switch Message-ID: References: <20230612075945.16330-1-arinc.unal@arinc9.com> <20230612075945.16330-4-arinc.unal@arinc9.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230612075945.16330-4-arinc.unal@arinc9.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Jun 12, 2023 at 10:59:41AM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL > > The check for setting the CPU_PORT bits must include the non-MT7621 SoC > MT7530 switch variants to trap frames. Expand the check to include them. ... and now you add support for this to the MT7530, which is what alerted me to what seems to be a mistake in the previous patch. "The setup of CPU_PORT() needs to be done for the MT7530 switch variants as well as the MT7621." -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!