From: Ido Schimmel <idosch@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: mkubecek@suse.cz, danieller@nvidia.com, netdev@vger.kernel.org,
linux@armlinux.org.uk, andrew@lunn.ch
Subject: Re: [PATCH ethtool-next v2 2/2] cmis: report LOL / LOS / Tx Fault
Date: Tue, 13 Jun 2023 10:32:05 +0300 [thread overview]
Message-ID: <ZIgbdYe289TsKhHi@shredder> (raw)
In-Reply-To: <20230613050507.1899596-2-kuba@kernel.org>
On Mon, Jun 12, 2023 at 10:05:07PM -0700, Jakub Kicinski wrote:
> Report whether Loss of Lock, of Signal and Tx Faults were detected.
> Print "None" in case no lane has the problem, and per-lane "Yes" /
> "No" if at least one of the lanes reports true.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
> ---
> Turns out I don't have access to any host with CMIS optics at this
> point so untested. I can only confirm it correctly shows nothing
> with a DAC...
I'm not sure why, but the module I have reports two banks and therefore
16 lanes. "Tx fault" and "Tx adaptive eq fault" are not supported.
When both are up:
# ethtool -m swp11 | grep "Rx loss of signal" -A 4
Rx loss of signal : None
Tx loss of signal : None
Rx loss of lock : None
Tx loss of lock : None
Module State : 0x03 (ModuleReady)
When I bring the other side down:
# ip link set dev swp12 down
# ethtool -m swp11 | grep "Rx loss of signal" -A 4
Rx loss of signal : [ Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes ]
Tx loss of signal : None
Rx loss of lock : [ Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes ]
Tx loss of lock : None
Module State : 0x03 (ModuleReady)
When I bring the interface itself down:
# ip link set dev swp11 down
# ethtool -m swp11 | grep "Rx loss of signal" -A 4
Rx loss of signal : [ Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes ]
Tx loss of signal : [ Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, No, No, No, No, No, No, No, No ]
Rx loss of lock : [ Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, No, No, No, No, No, No, No, No ]
Tx loss of lock : [ Yes, Yes, Yes, Yes, Yes, Yes, Yes, Yes, No, No, No, No, No, No, No, No ]
Module State : 0x03 (ModuleReady)
And I don't see these fields on PC:
# ethtool -m swp1 | grep "Rx loss of signal" -A 4
next prev parent reply other threads:[~2023-06-13 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 5:05 [PATCH ethtool-next v2 1/2] sff-8636: report LOL / LOS / Tx Fault Jakub Kicinski
2023-06-13 5:05 ` [PATCH ethtool-next v2 2/2] cmis: " Jakub Kicinski
2023-06-13 7:32 ` Ido Schimmel [this message]
2023-06-13 16:48 ` Jakub Kicinski
2023-06-13 7:06 ` [PATCH ethtool-next v2 1/2] sff-8636: " Ido Schimmel
2023-06-14 18:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIgbdYe289TsKhHi@shredder \
--to=idosch@nvidia.com \
--cc=andrew@lunn.ch \
--cc=danieller@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).