From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8E1A12B77 for ; Tue, 13 Jun 2023 13:03:12 +0000 (UTC) Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 793531BCD; Tue, 13 Jun 2023 06:02:48 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1q93fX-0000Gp-MM; Tue, 13 Jun 2023 15:02:43 +0200 Date: Tue, 13 Jun 2023 15:02:43 +0200 From: Florian Westphal To: Paul Blakey Cc: Vlad Buslov , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Oz Shlomo , Roi Dayan , Saeed Mahameed , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko Subject: Re: [PATCH net 1/1] net/sched: act_ct: Fix promotion of offloaded unreplied tuple Message-ID: References: <1686313379-117663-1-git-send-email-paulb@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1686313379-117663-1-git-send-email-paulb@nvidia.com> X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Paul Blakey wrote: > Currently UNREPLIED and UNASSURED connections are added to the nf flow > table. This causes the following connection packets to be processed > by the flow table which then skips conntrack_in(), and thus such the > connections will remain UNREPLIED and UNASSURED even if reply traffic > is then seen. Even still, the unoffloaded reply packets are the ones > triggering hardware update from new to established state, and if > there aren't any to triger an update and/or previous update was > missed, hardware can get out of sync with sw and still mark > packets as new. Reviewed-by: Florian Westphal