From: Richard Cochran <richardcochran@gmail.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH net-next v2 2/2] net: micrel: Schedule work to read seconds for lan8841
Date: Tue, 13 Jun 2023 21:49:38 -0700 [thread overview]
Message-ID: <ZIlG4otXfQ7uhMsc@hoboy.vegasvil.org> (raw)
In-Reply-To: <20230613094526.69532-3-horatiu.vultur@microchip.com>
On Tue, Jun 13, 2023 at 11:45:26AM +0200, Horatiu Vultur wrote:
> @@ -3840,6 +3847,12 @@ static void lan8841_ptp_enable_processing(struct kszphy_ptp_priv *ptp_priv,
> LAN8841_PTP_INSERT_TS_32BIT,
> LAN8841_PTP_INSERT_TS_EN |
> LAN8841_PTP_INSERT_TS_32BIT);
> +
> + /* Schedule the work to read the seconds, which will be used in
> + * the received timestamp
> + */
> + schedule_delayed_work(&ptp_priv->seconds_work,
> + nsecs_to_jiffies(LAN8841_GET_SEC_LTC_DELAY));
Why not do this in the PTP kworker thread?
The thread's scheduling can be easily tuned with chrt to give it
appropriate priority, but work can't.
Also, If you have seconds thread, then you don't have to defer the
received frames.
Thanks,
Richard
next prev parent reply other threads:[~2023-06-14 4:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 9:45 [PATCH net-next v2 0/2] net: micrel: Change how to read TX timestamp Horatiu Vultur
2023-06-13 9:45 ` [PATCH net-next v2 1/2] net: micrel: Change to receive timestamp in the frame for lan8841 Horatiu Vultur
2023-06-14 5:06 ` Richard Cochran
2023-06-13 9:45 ` [PATCH net-next v2 2/2] net: micrel: Schedule work to read seconds " Horatiu Vultur
2023-06-14 4:49 ` Richard Cochran [this message]
2023-06-14 9:19 ` Horatiu Vultur
2023-06-13 11:38 ` [PATCH net-next v2 0/2] net: micrel: Change how to read TX timestamp Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIlG4otXfQ7uhMsc@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox