From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Piotr Gardocki <piotrx.gardocki@intel.com>
Cc: <netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
<przemyslaw.kitszel@intel.com>,
<michal.swiatkowski@linux.intel.com>, <pmenzel@molgen.mpg.de>,
<kuba@kernel.org>, <anthony.l.nguyen@intel.com>,
<simon.horman@corigine.com>, <aleksander.lobakin@intel.com>
Subject: Re: [PATCH net-next v3 0/3] optimize procedure of changing MAC address on interface
Date: Wed, 14 Jun 2023 17:50:01 +0200 [thread overview]
Message-ID: <ZInhqR2RspvkMOYF@boxer> (raw)
In-Reply-To: <20230614145302.902301-1-piotrx.gardocki@intel.com>
On Wed, Jun 14, 2023 at 04:52:59PM +0200, Piotr Gardocki wrote:
> The first patch adds an if statement in core to skip early when
> the MAC address is not being changes.
> The remaining patches remove such checks from Intel drivers
> as they're redundant at this point.
>
> v3: removed "This patch ..." from first patch to simplify sentence.
> v2: modified check in core to support addresses of any length,
> removed redundant checks in i40e and ice
Any particular reason for not including my rev-by tags on driver patches?
>
> Piotr Gardocki (3):
> net: add check for current MAC address in dev_set_mac_address
> i40e: remove unnecessary check for old MAC == new MAC
> ice: remove unnecessary check for old MAC == new MAC
>
> drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ------
> drivers/net/ethernet/intel/ice/ice_main.c | 5 -----
> net/core/dev.c | 2 ++
> 3 files changed, 2 insertions(+), 11 deletions(-)
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-06-14 15:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 14:52 [PATCH net-next v3 0/3] optimize procedure of changing MAC address on interface Piotr Gardocki
2023-06-14 14:53 ` [PATCH net-next v3 1/3] net: add check for current MAC address in dev_set_mac_address Piotr Gardocki
2023-06-15 11:34 ` Simon Horman
2023-06-14 14:53 ` [PATCH net-next v3 2/3] i40e: remove unnecessary check for old MAC == new MAC Piotr Gardocki
2023-06-15 11:34 ` Simon Horman
2023-06-14 14:53 ` [PATCH net-next v3 3/3] ice: " Piotr Gardocki
2023-06-15 11:34 ` Simon Horman
2023-06-14 15:50 ` Maciej Fijalkowski [this message]
2023-06-14 15:52 ` [PATCH net-next v3 0/3] optimize procedure of changing MAC address on interface Piotr Gardocki
2023-06-14 15:53 ` Maciej Fijalkowski
2023-06-15 7:31 ` Simon Horman
2023-06-15 8:51 ` Piotr Gardocki
2023-06-15 11:31 ` Simon Horman
2023-06-16 6:00 ` patchwork-bot+netdevbpf
2023-06-16 10:02 ` Fijalkowski, Maciej
2023-06-16 15:29 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZInhqR2RspvkMOYF@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotrx.gardocki@intel.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).