From: Simon Horman <simon.horman@corigine.com>
To: Piotr Gardocki <piotrx.gardocki@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
przemyslaw.kitszel@intel.com, michal.swiatkowski@linux.intel.com,
pmenzel@molgen.mpg.de, kuba@kernel.org,
maciej.fijalkowski@intel.com, anthony.l.nguyen@intel.com,
aleksander.lobakin@intel.com
Subject: Re: [PATCH net-next v3 0/3] optimize procedure of changing MAC address on interface
Date: Thu, 15 Jun 2023 13:31:20 +0200 [thread overview]
Message-ID: <ZIr2iNTFcWV4Tdjc@corigine.com> (raw)
In-Reply-To: <e15cba8a-8e3d-e804-ba8e-6feea374f1f9@intel.com>
On Thu, Jun 15, 2023 at 10:51:28AM +0200, Piotr Gardocki wrote:
> On 15.06.2023 09:31, Simon Horman wrote:
> > On Wed, Jun 14, 2023 at 04:52:59PM +0200, Piotr Gardocki wrote:
> >> The first patch adds an if statement in core to skip early when
> >> the MAC address is not being changes.
> >> The remaining patches remove such checks from Intel drivers
> >> as they're redundant at this point.
> >
> > Hi Pitor,
> >
> > I am wondering if you audited other drivers to see if they
> > could also be updated in a similar way to the Intel changes
> > in this patch-set.
>
> Hi Simon,
>
> We already discussed this in "[PATCH net-next v2 3/3]". Other drivers
> should be audited at one point, but there are hundreds of ndo_set_mac_address
> callbacks in kernel and I don't have resources to review all of them. I just
> fixed Intel drivers for now.
> When this patch set is applied someone else can work on that.
Sorry, I forgot about that discussion.
Of course this is fine.
next prev parent reply other threads:[~2023-06-15 11:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 14:52 [PATCH net-next v3 0/3] optimize procedure of changing MAC address on interface Piotr Gardocki
2023-06-14 14:53 ` [PATCH net-next v3 1/3] net: add check for current MAC address in dev_set_mac_address Piotr Gardocki
2023-06-15 11:34 ` Simon Horman
2023-06-14 14:53 ` [PATCH net-next v3 2/3] i40e: remove unnecessary check for old MAC == new MAC Piotr Gardocki
2023-06-15 11:34 ` Simon Horman
2023-06-14 14:53 ` [PATCH net-next v3 3/3] ice: " Piotr Gardocki
2023-06-15 11:34 ` Simon Horman
2023-06-14 15:50 ` [PATCH net-next v3 0/3] optimize procedure of changing MAC address on interface Maciej Fijalkowski
2023-06-14 15:52 ` Piotr Gardocki
2023-06-14 15:53 ` Maciej Fijalkowski
2023-06-15 7:31 ` Simon Horman
2023-06-15 8:51 ` Piotr Gardocki
2023-06-15 11:31 ` Simon Horman [this message]
2023-06-16 6:00 ` patchwork-bot+netdevbpf
2023-06-16 10:02 ` Fijalkowski, Maciej
2023-06-16 15:29 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIr2iNTFcWV4Tdjc@corigine.com \
--to=simon.horman@corigine.com \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotrx.gardocki@intel.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).