From: Simon Horman <simon.horman@corigine.com>
To: Piotr Gardocki <piotrx.gardocki@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
przemyslaw.kitszel@intel.com, michal.swiatkowski@linux.intel.com,
pmenzel@molgen.mpg.de, kuba@kernel.org,
maciej.fijalkowski@intel.com, anthony.l.nguyen@intel.com,
aleksander.lobakin@intel.com
Subject: Re: [PATCH net-next v3 1/3] net: add check for current MAC address in dev_set_mac_address
Date: Thu, 15 Jun 2023 13:34:22 +0200 [thread overview]
Message-ID: <ZIr3PibwAkAVLrIU@corigine.com> (raw)
In-Reply-To: <20230614145302.902301-2-piotrx.gardocki@intel.com>
On Wed, Jun 14, 2023 at 04:53:00PM +0200, Piotr Gardocki wrote:
> In some cases it is possible for kernel to come with request
> to change primary MAC address to the address that is already
> set on the given interface.
>
> Add proper check to return fast from the function in these cases.
>
> An example of such case is adding an interface to bonding
> channel in balance-alb mode:
> modprobe bonding mode=balance-alb miimon=100 max_bonds=1
> ip link set bond0 up
> ifenslave bond0 <eth>
>
> Signed-off-by: Piotr Gardocki <piotrx.gardocki@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-06-15 11:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 14:52 [PATCH net-next v3 0/3] optimize procedure of changing MAC address on interface Piotr Gardocki
2023-06-14 14:53 ` [PATCH net-next v3 1/3] net: add check for current MAC address in dev_set_mac_address Piotr Gardocki
2023-06-15 11:34 ` Simon Horman [this message]
2023-06-14 14:53 ` [PATCH net-next v3 2/3] i40e: remove unnecessary check for old MAC == new MAC Piotr Gardocki
2023-06-15 11:34 ` Simon Horman
2023-06-14 14:53 ` [PATCH net-next v3 3/3] ice: " Piotr Gardocki
2023-06-15 11:34 ` Simon Horman
2023-06-14 15:50 ` [PATCH net-next v3 0/3] optimize procedure of changing MAC address on interface Maciej Fijalkowski
2023-06-14 15:52 ` Piotr Gardocki
2023-06-14 15:53 ` Maciej Fijalkowski
2023-06-15 7:31 ` Simon Horman
2023-06-15 8:51 ` Piotr Gardocki
2023-06-15 11:31 ` Simon Horman
2023-06-16 6:00 ` patchwork-bot+netdevbpf
2023-06-16 10:02 ` Fijalkowski, Maciej
2023-06-16 15:29 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIr3PibwAkAVLrIU@corigine.com \
--to=simon.horman@corigine.com \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotrx.gardocki@intel.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).