* [PATCH] wifi: mac80211: Remove "Missing iftype sband data/EHT cap" spam
@ 2023-06-14 13:26 Nicolas Cavallari
2023-06-15 9:33 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Cavallari @ 2023-06-14 13:26 UTC (permalink / raw)
To: Johannes Berg, Ilan Peer
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
linux-wireless, netdev
In mesh mode, ieee80211_chandef_he_6ghz_oper() is called by
mesh_matches_local() for every received mesh beacon.
On a 6 GHz mesh of a HE-only phy, this spams that the hardware does not
have EHT capabilities, even if the received mesh beacon does not have an
EHT element.
Unlike HE, not supporting EHT in the 6 GHz band is not an error so do
not print anything in this case.
Fixes: 5dca295dd767 ("mac80211: Add initial support for EHT and 320 MHz channels")
Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
---
net/mac80211/util.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index 3bd07a0a782f..325a1e107240 100644
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -3801,10 +3801,8 @@ bool ieee80211_chandef_he_6ghz_oper(struct ieee80211_sub_if_data *sdata,
}
eht_cap = ieee80211_get_eht_iftype_cap(sband, iftype);
- if (!eht_cap) {
- sdata_info(sdata, "Missing iftype sband data/EHT cap");
+ if (!eht_cap)
eht_oper = NULL;
- }
he_6ghz_oper = ieee80211_he_6ghz_oper(he_oper);
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wifi: mac80211: Remove "Missing iftype sband data/EHT cap" spam
2023-06-14 13:26 [PATCH] wifi: mac80211: Remove "Missing iftype sband data/EHT cap" spam Nicolas Cavallari
@ 2023-06-15 9:33 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2023-06-15 9:33 UTC (permalink / raw)
To: Nicolas Cavallari
Cc: Johannes Berg, Ilan Peer, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-wireless, netdev
On Wed, Jun 14, 2023 at 03:26:48PM +0200, Nicolas Cavallari wrote:
> In mesh mode, ieee80211_chandef_he_6ghz_oper() is called by
> mesh_matches_local() for every received mesh beacon.
>
> On a 6 GHz mesh of a HE-only phy, this spams that the hardware does not
> have EHT capabilities, even if the received mesh beacon does not have an
> EHT element.
>
> Unlike HE, not supporting EHT in the 6 GHz band is not an error so do
> not print anything in this case.
>
> Fixes: 5dca295dd767 ("mac80211: Add initial support for EHT and 320 MHz channels")
>
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-15 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-14 13:26 [PATCH] wifi: mac80211: Remove "Missing iftype sband data/EHT cap" spam Nicolas Cavallari
2023-06-15 9:33 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).