From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <bjorn@kernel.org>, <magnus.karlsson@intel.com>,
<jonathan.lemon@gmail.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<maxtram95@gmail.com>
Subject: Re: [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard()
Date: Thu, 15 Jun 2023 15:51:49 +0200 [thread overview]
Message-ID: <ZIsXdcawAWc/9Izo@boxer> (raw)
In-Reply-To: <ZIsW47S1Pdzqxkxt@boxer>
On Thu, Jun 15, 2023 at 03:49:23PM +0200, Maciej Fijalkowski wrote:
> On Thu, Jun 15, 2023 at 08:46:12PM +0800, YueHaibing wrote:
> > commit f2f167583601 ("xsk: Remove unused xsk_buff_discard")
> > left behind this, remove it.
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Yeah this is a stub for !CONFIG_XDP_SOCKETS...
Wait, I am not sure if this should go to bpf tree and have fixes tag
pointing to the cited commit?
Functionally this commit does not fix anything but it feels that
f2f167583601 was incomplete.
>
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>
> > ---
> > include/net/xdp_sock_drv.h | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/include/net/xdp_sock_drv.h b/include/net/xdp_sock_drv.h
> > index 9c0d860609ba..c243f906ebed 100644
> > --- a/include/net/xdp_sock_drv.h
> > +++ b/include/net/xdp_sock_drv.h
> > @@ -255,10 +255,6 @@ static inline void xsk_buff_free(struct xdp_buff *xdp)
> > {
> > }
> >
> > -static inline void xsk_buff_discard(struct xdp_buff *xdp)
> > -{
> > -}
> > -
> > static inline void xsk_buff_set_size(struct xdp_buff *xdp, u32 size)
> > {
> > }
> > --
> > 2.34.1
> >
> >
next prev parent reply other threads:[~2023-06-15 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 12:46 [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard() YueHaibing
2023-06-15 13:49 ` Maciej Fijalkowski
2023-06-15 13:51 ` Maciej Fijalkowski [this message]
2023-06-15 14:40 ` Simon Horman
2023-06-16 1:34 ` YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIsXdcawAWc/9Izo@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=maxtram95@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).