From: Simon Horman <simon.horman@corigine.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: dsa: tag_sja1105: fix MAC DA patching from meta frames
Date: Fri, 30 Jun 2023 15:29:25 +0200 [thread overview]
Message-ID: <ZJ7YtXGLZDuV+az1@corigine.com> (raw)
In-Reply-To: <20230629141453.1112919-2-vladimir.oltean@nxp.com>
On Thu, Jun 29, 2023 at 05:14:52PM +0300, Vladimir Oltean wrote:
> The SJA1105 manual says that at offset 4 into the meta frame payload we
> have "MAC destination byte 2" and at offset 5 we have "MAC destination
> byte 1". These are counted from the LSB, so byte 1 is h_dest[ETH_HLEN-2]
> aka h_dest[4] and byte 2 is h_dest[ETH_HLEN-3] aka h_dest[3].
>
> The sja1105_meta_unpack() function decodes these the other way around,
> so a frame with MAC DA 01:80:c2:11:22:33 is received by the network
> stack as having 01:80:c2:22:11:33.
>
> Fixes: e53e18a6fe4d ("net: dsa: sja1105: Receive and decode meta frames")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next parent reply other threads:[~2023-06-30 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230629141453.1112919-1-vladimir.oltean@nxp.com>
[not found] ` <20230629141453.1112919-2-vladimir.oltean@nxp.com>
2023-06-30 13:29 ` Simon Horman [this message]
2023-07-02 14:37 ` [PATCH net 1/2] net: dsa: tag_sja1105: fix MAC DA patching from meta frames Florian Fainelli
[not found] ` <20230629141453.1112919-3-vladimir.oltean@nxp.com>
2023-06-30 13:35 ` [PATCH net 2/2] net: dsa: sja1105: always enable the send_meta options Simon Horman
2023-06-30 16:53 ` Vladimir Oltean
2023-06-30 17:38 ` Simon Horman
2023-07-02 14:39 ` Florian Fainelli
2023-07-03 20:33 ` [PATCH net 0/2] Fix mangled link-local MAC DAs with SJA1105 DSA Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ7YtXGLZDuV+az1@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).