From: Simon Horman <simon.horman@corigine.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev <netdev@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Christian Marangi <ansuelsmth@gmail.com>
Subject: Re: [PATCH net-next v1 2/3] net: phy: phy_device: Call into the PHY driver to set LED offload
Date: Wed, 21 Jun 2023 15:39:22 +0200 [thread overview]
Message-ID: <ZJL9impjnKMGFTWf@corigine.com> (raw)
In-Reply-To: <20230619215703.4038619-3-andrew@lunn.ch>
On Mon, Jun 19, 2023 at 11:57:02PM +0200, Andrew Lunn wrote:
> Linux LEDs can be requested to perform hardware accelerated blinking
> to indicate link, RX, TX etc. Pass the rules for blinking to the PHY
> driver, if it implements the ops needed to determine if a given
> pattern can be offloaded, to offload it, and what the current offload
> is. Additionally implement the op needed to get what device the LED is
> for.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-06-21 13:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 21:57 [PATCH net-next v1 0/3] Support offload LED blinking to PHY Andrew Lunn
2023-06-19 21:57 ` [PATCH net-next v1 1/3] led: trig: netdev: Fix requesting offload device Andrew Lunn
2023-06-21 13:37 ` Simon Horman
2023-06-21 15:19 ` Andrew Lunn
2023-06-21 15:34 ` Simon Horman
2023-06-19 21:57 ` [PATCH net-next v1 2/3] net: phy: phy_device: Call into the PHY driver to set LED offload Andrew Lunn
2023-06-21 13:39 ` Simon Horman [this message]
2023-06-21 22:24 ` Jakub Kicinski
2023-06-21 22:28 ` Jakub Kicinski
2023-06-19 21:57 ` [PATCH net-next v1 3/3] net: phy: marvell: Add support for offloading LED blinking Andrew Lunn
2023-06-21 13:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJL9impjnKMGFTWf@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).