From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32E3BC147 for ; Wed, 21 Jun 2023 11:53:30 +0000 (UTC) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24F7D1706 for ; Wed, 21 Jun 2023 04:53:28 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-31272fcedf6so2795338f8f.2 for ; Wed, 21 Jun 2023 04:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1687348406; x=1689940406; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=VWVbrBam1C3VHFxu2Gp+YYi2JGVprd45HzgEWZLjxNI=; b=m4NkOGZMB4TCMVjcELrLjRRubYuX8F1IGWT0PfmzIQSLSjXRajmdfJhKqn4XFjJL+Q eRCVpVSB9sTomVtJdbAvTYMqrY35FdnFXS+piL/ZI7D4zTYkVVedZ4O45KfmXLmZUmSo dyPWKtwtIy+G5RM0B3ciFRoFRa0lqxrvgkrp2/PjoYCGJsHAq2Wq8zqQYRzOVhtfVYOP bEEsyZvxH68MlHiWvEyHpHQNL866S4AvvqoMfRvV3ekbZI6I04U0pddSwK6oWF392SYg W5HB6vUWMe46K8v9Oi+tVhbAblBpJPnZ0bxSwYrNwrPDxP9NpOOKqSd0D/S3sPMWblaF 86gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687348406; x=1689940406; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VWVbrBam1C3VHFxu2Gp+YYi2JGVprd45HzgEWZLjxNI=; b=hspI3eR73ux27zzW7ugyVUlpwq0KKrvUInuL7Nj5xLZMiPD96XkODidwKGwHOZ3x1R sfVyDXzXXi9UbU+6mj4e+n8cycLvFEMgti7Meze/o9EJhe8ymEUIsJJREnhasB3gvPri W/MNMWirMmnzCZ+yHcZrclYgrhrJ0I2Bg+4TrVL725uDRRq5fQlhWoNkUCpA6rKkuWgj jqqq41jZCaYPBGGQOrmq5+q657rWTEADrISdjdR2yOLVU7vJO3hXnJt1gLOlHQ4EOIqR zL10YJxqCtoWwJusDsDbnpn+c5HQaca31J/XLn5oHT32hDztTq7Qp+T5Jw38oE+c9NiV DXhQ== X-Gm-Message-State: AC+VfDyfBp1UUlxOXZtrBh9v3Kt2H9k8tZFSOyphdFYMDxDrQZzHvpGZ 9HJNQyRs/3k058mHm7Zl/71SpQ== X-Google-Smtp-Source: ACHHUZ5c8gzF87ZPOzSygN9j53VtOdiY9gi5DBzBT3zEwY7bTIXpP8dgWGQLA/+KsDQtBIq8+e5vDw== X-Received: by 2002:a05:6000:1252:b0:311:1712:621 with SMTP id j18-20020a056000125200b0031117120621mr10087707wrx.46.1687348406491; Wed, 21 Jun 2023 04:53:26 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id b8-20020adff248000000b003063772a55bsm4283305wrp.61.2023.06.21.04.53.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 04:53:25 -0700 (PDT) Date: Wed, 21 Jun 2023 13:53:24 +0200 From: Jiri Pirko To: Petr Oros Cc: Arkadiusz Kubalewski , kuba@kernel.org, vadfed@meta.com, jonathan.lemon@gmail.com, pabeni@redhat.com, corbet@lwn.net, davem@davemloft.net, edumazet@google.com, vadfed@fb.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, saeedm@nvidia.com, leon@kernel.org, richardcochran@gmail.com, sj@kernel.org, javierm@redhat.com, ricardo.canuelo@collabora.com, mst@redhat.com, tzimmermann@suse.de, michal.michalik@intel.com, gregkh@linuxfoundation.org, jacek.lawrynowicz@linux.intel.com, airlied@redhat.com, ogabbay@kernel.org, arnd@arndb.de, nipun.gupta@amd.com, axboe@kernel.dk, linux@zary.sk, masahiroy@kernel.org, benjamin.tissoires@redhat.com, geert+renesas@glider.be, milena.olech@intel.com, kuniyu@amazon.com, liuhangbin@gmail.com, hkallweit1@gmail.com, andy.ren@getcruise.com, razor@blackwall.org, idosch@nvidia.com, lucien.xin@gmail.com, nicolas.dichtel@6wind.com, phil@nwl.cc, claudiajkang@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mschmidt@redhat.com, linux-clk@vger.kernel.org, vadim.fedorenko@linux.dev Subject: Re: [RFC PATCH v8 04/10] dpll: netlink: Add DPLL framework base functions Message-ID: References: <20230609121853.3607724-1-arkadiusz.kubalewski@intel.com> <20230609121853.3607724-5-arkadiusz.kubalewski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Wed, Jun 21, 2023 at 01:18:59PM CEST, poros@redhat.com wrote: >Arkadiusz Kubalewski píše v Pá 09. 06. 2023 v 14:18 +0200: >> From: Vadim Fedorenko [...] Could you perhaps cut out the text you don't comment? Saves some time finding your reply. >> +static int >> +dpll_set_from_nlattr(struct dpll_device *dpll, struct genl_info >> *info) >> +{ >> +       const struct dpll_device_ops *ops = dpll_device_ops(dpll); >> +       struct nlattr *tb[DPLL_A_MAX + 1]; >> +       int ret = 0; >> + >> +       nla_parse(tb, DPLL_A_MAX, genlmsg_data(info->genlhdr), >> +                 genlmsg_len(info->genlhdr), NULL, info->extack); >> +       if (tb[DPLL_A_MODE]) { >Hi, > >Here should be something like: > if (!ops->mode_set) > return -EOPNOTSUPP; Why? All drivers implement that. I believe that it's actullaly better that way. For a called setting up the same mode it is the dpll in, there should be 0 return by the driver. Note that driver holds this value. I'd like to keep this code as it is. [...]