From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22F1B1FB4 for ; Thu, 22 Jun 2023 07:06:13 +0000 (UTC) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C6751BD5 for ; Thu, 22 Jun 2023 00:05:59 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3f9b258f3a2so43844875e9.0 for ; Thu, 22 Jun 2023 00:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1687417557; x=1690009557; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VIhSOYk52hVuqfcboW85OQLI0NHly7jy25hrkyJ2YAw=; b=WZQ2qdOUncD9AsxUeqky0Sv9plZI/2WtRmFLj/vUPrLspAKtFdJAjDNBfRiM90Wl6l Bu52No9UiIMeNp5vJfqV4tdzKNy4gqSSkZZgdTA2tEhX9UhJ0VFvTD1WUjcyZjBnxsqM CY6kI+W0r2aC0t58Ot4ae4EkJpbEUxEO+qU0IzQugmgTpIX9f4Vdc6bAsBsmzf0/VZPu oMD/OCT9ypK+CBaNDZaMdjjZbvVgK6KKjigdSYdUY6tPiNMyp/u8BcNpj7C6Q76VkPqd cFeXbCEhZGKbNKcefxvBWXoomyu9ZEWY69AGbsxFJ97j4shY74xka5Cdz8D7NjEiYYcZ YJOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687417557; x=1690009557; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VIhSOYk52hVuqfcboW85OQLI0NHly7jy25hrkyJ2YAw=; b=NxhzpKoBxvPEGQXyvpP4DsJeDsWGKvWlh+r71Sq+xIPUtwGNQbDbl5KwEKt9/mOLRk FM0BM3I+tFlTQKmWP7m1Yi+vniCBerZUxJKVfWL+AmNJ/mRGHszQbrneclv0OrNlBshm Wye0T3pgJocekQHgvyFaNWHrbx6xGcFc9a9aD+E1BMVUHqD7Dvm5CjQVGckrxqJW6IwJ OymZHmPK3pf1/uR0yT2TPsidTuZs+4luyyZ2ts1/jaIZ2cvdqL5ppYM2Jna8qPihnxeM j3Xv/4hHso5zX7Wih/b5PQnuSBLbQbX0FvONK7kAQAECLtKLJxhgolovtYN3qjS5pa4u wyFg== X-Gm-Message-State: AC+VfDztXqBu5dDzjx1UllMqJ7+lmJunZtjLgc6McRp0/Sinm9h6cE4B hNE8v/8T19l/6+fg4PDNmMTKeA== X-Google-Smtp-Source: ACHHUZ47nqUaHErWDVz/sLK5UcH8SW19SUG16keT/oe5Rk5/giZmsiFYSgziHOgHrlK6XzxNNrCLiA== X-Received: by 2002:a1c:7415:0:b0:3fa:77c8:6724 with SMTP id p21-20020a1c7415000000b003fa77c86724mr51349wmc.10.1687417557595; Thu, 22 Jun 2023 00:05:57 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id 17-20020a05600c231100b003f8ec58995fsm6919930wmo.6.2023.06.22.00.05.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 00:05:57 -0700 (PDT) Date: Thu, 22 Jun 2023 09:05:56 +0200 From: Jiri Pirko To: "Kubalewski, Arkadiusz" Cc: "kuba@kernel.org" , "vadfed@meta.com" , "jonathan.lemon@gmail.com" , "pabeni@redhat.com" , "corbet@lwn.net" , "davem@davemloft.net" , "edumazet@google.com" , "vadfed@fb.com" , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "M, Saeed" , "leon@kernel.org" , "richardcochran@gmail.com" , "sj@kernel.org" , "javierm@redhat.com" , "ricardo.canuelo@collabora.com" , "mst@redhat.com" , "tzimmermann@suse.de" , "Michalik, Michal" , "gregkh@linuxfoundation.org" , "jacek.lawrynowicz@linux.intel.com" , "airlied@redhat.com" , "ogabbay@kernel.org" , "arnd@arndb.de" , "nipun.gupta@amd.com" , "axboe@kernel.dk" , "linux@zary.sk" , "masahiroy@kernel.org" , "benjamin.tissoires@redhat.com" , "geert+renesas@glider.be" , "Olech, Milena" , "kuniyu@amazon.com" , "liuhangbin@gmail.com" , "hkallweit1@gmail.com" , "andy.ren@getcruise.com" , "razor@blackwall.org" , "idosch@nvidia.com" , "lucien.xin@gmail.com" , "nicolas.dichtel@6wind.com" , "phil@nwl.cc" , "claudiajkang@gmail.com" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-rdma@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "linux-clk@vger.kernel.org" , "vadim.fedorenko@linux.dev" Subject: Re: [RFC PATCH v8 03/10] dpll: core: Add DPLL framework base functions Message-ID: References: <20230609121853.3607724-1-arkadiusz.kubalewski@intel.com> <20230609121853.3607724-4-arkadiusz.kubalewski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Wed, Jun 21, 2023 at 08:55:35PM CEST, arkadiusz.kubalewski@intel.com wrote: >>From: Jiri Pirko >>Sent: Saturday, June 10, 2023 7:38 PM >> >>Fri, Jun 09, 2023 at 02:18:46PM CEST, arkadiusz.kubalewski@intel.com wrote: >>>From: Vadim Fedorenko >>> >>>DPLL framework is used to represent and configure DPLL devices >>>in systems. Each device that has DPLL and can configure inputs >>>and outputs can use this framework. >>> >>>Implement core framework functions for further interactions >>>with device drivers implementing dpll subsystem, as well as for >>>interactions of DPLL netlink framework part with the subsystem >>>itself. >>> >>>Co-developed-by: Milena Olech >>>Signed-off-by: Milena Olech >>>Co-developed-by: Michal Michalik >>>Signed-off-by: Michal Michalik >>>Signed-off-by: Vadim Fedorenko >>>Co-developed-by: Arkadiusz Kubalewski >>>Signed-off-by: Arkadiusz Kubalewski >>>--- >>> drivers/dpll/dpll_core.c | 953 +++++++++++++++++++++++++++++++++++++++ >>> drivers/dpll/dpll_core.h | 104 +++++ >> >>Overall, looks very good! I pinpointed couple of nits below, nothing big. >>General question: Why do you put documentation comment to every static >>function? Does not make any sense to me. Even for non-exported functions >>I think it is overkill. Most of them (if not all) give the reader no >>additional information and only make the code a bit harder to read. >>Care to drop them? >> > >I forgot to respond here.. I would rather leave it, but if the others think >the same way, we could remove them. Could you explain what is the benefit of leaving them? What are they good for. From what I see, they are obvious and only add blank LOC.