From: Sabrina Dubroca <sd@queasysnail.net>
To: Carlos Fernandez <carlos.fernandez@technica-engineering.de>
Cc: Jakub Kicinski <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] net: macsec SCI assignment for ES = 0
Date: Thu, 22 Jun 2023 21:54:53 +0200 [thread overview]
Message-ID: <ZJSnDZL-0hLxbDje@hog> (raw)
In-Reply-To: <AM9PR08MB67887483EDDF2AB7B11BF14FDB22A@AM9PR08MB6788.eurprd08.prod.outlook.com>
Hi Carlos,
2023-06-22, 11:49:44 +0000, Carlos Fernandez wrote:
> Hi Jakub,
>
> Also, about the double look up:
> I know it's there, but I tried to only change the function that returns the correct SCI in every case. Also, it should be a 1 and only item list. I do not think this should be dangerous or slow.
Why is it a 1 item list? Even if that was guaranteed to be true in
normal conditions, we could have a situation where lots of MACsec
SecYs and RXSCs are set up, and packets start hitting this loop.
And could you quote the correct section of 802.1AE? I can't find the
reference for the behavior you're implementing in this patch. All I
can find is (from section 9.5):
The ES bit is clear if the Source Address is not used to determine the SCI.
The SC bit shall be clear if an SCI is not present in the SecTAG.
which doesn't say anything about how to interpret both bits being
clear.
(and please don't top-post)
Thanks,
--
Sabrina
next prev parent reply other threads:[~2023-06-22 19:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 9:13 [PATCH v3] net: macsec SCI assignment for ES = 0 carlos.fernandez
2023-06-22 0:34 ` Jakub Kicinski
2023-06-22 8:00 ` Carlos Fernandez
2023-06-22 11:49 ` Carlos Fernandez
2023-06-22 19:54 ` Sabrina Dubroca [this message]
2023-06-23 10:13 ` carlos.fernandez
2023-06-23 15:40 ` Sabrina Dubroca
2023-06-27 6:13 ` carlos.fernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJSnDZL-0hLxbDje@hog \
--to=sd@queasysnail.net \
--cc=carlos.fernandez@technica-engineering.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).