From: Sabrina Dubroca <sd@queasysnail.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, simon.horman@corigine.com
Subject: Re: [PATCH net-next v2] netdevsim: add dummy macsec offload
Date: Thu, 22 Jun 2023 22:02:42 +0200 [thread overview]
Message-ID: <ZJSo4lmt58B_66-3@hog> (raw)
In-Reply-To: <20230621131834.345f4f60@kernel.org>
2023-06-21, 13:18:34 -0700, Jakub Kicinski wrote:
> On Wed, 21 Jun 2023 15:14:46 +0200 Sabrina Dubroca wrote:
> > When the kernel is compiled with MACsec support, add the
> > NETIF_F_HW_MACSEC feature to netdevsim devices and implement
> > macsec_ops.
> >
> > To allow easy testing of failure from the device, support is limited
> > to 3 SecY's per netdevsim device, and 1 RXSC per SecY.
>
> Quoting documentation:
>
> netdevsim
> ~~~~~~~~~
>
> [...]
>
> ``netdevsim`` is reserved for use by upstream tests only, so any
> new ``netdevsim`` features must be accompanied by selftests under
> ``tools/testing/selftests/``.
>
> See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#netdevsim
Ugh, sorry. I'll repost as a series with a selftest.
> --
> pw-bot: cr
--
Sabrina
prev parent reply other threads:[~2023-06-22 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 13:14 [PATCH net-next v2] netdevsim: add dummy macsec offload Sabrina Dubroca
2023-06-21 14:33 ` Simon Horman
2023-06-21 20:18 ` Jakub Kicinski
2023-06-22 20:02 ` Sabrina Dubroca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJSo4lmt58B_66-3@hog \
--to=sd@queasysnail.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).