* [PATCH net] selftests: rtnetlink: remove netdevsim device after ipsec offload test
@ 2023-06-22 21:03 Sabrina Dubroca
2023-06-23 6:53 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sabrina Dubroca @ 2023-06-22 21:03 UTC (permalink / raw)
To: netdev; +Cc: Sabrina Dubroca, Jiri Pirko, Shuah Khan, linux-kselftest
On systems where netdevsim is built-in or loaded before the test
starts, kci_test_ipsec_offload doesn't remove the netdevsim device it
created during the test.
Fixes: e05b2d141fef ("netdevsim: move netdev creation/destruction to dev probe")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
---
tools/testing/selftests/net/rtnetlink.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh
index 383ac6fc037d..ba286d680fd9 100755
--- a/tools/testing/selftests/net/rtnetlink.sh
+++ b/tools/testing/selftests/net/rtnetlink.sh
@@ -860,6 +860,7 @@ EOF
fi
# clean up any leftovers
+ echo 0 > /sys/bus/netdevsim/del_device
$probed && rmmod netdevsim
if [ $ret -ne 0 ]; then
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] selftests: rtnetlink: remove netdevsim device after ipsec offload test
2023-06-22 21:03 [PATCH net] selftests: rtnetlink: remove netdevsim device after ipsec offload test Sabrina Dubroca
@ 2023-06-23 6:53 ` Simon Horman
2023-06-23 7:46 ` Jiri Pirko
2023-06-24 22:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2023-06-23 6:53 UTC (permalink / raw)
To: Sabrina Dubroca; +Cc: netdev, Jiri Pirko, Shuah Khan, linux-kselftest
On Thu, Jun 22, 2023 at 11:03:34PM +0200, Sabrina Dubroca wrote:
> On systems where netdevsim is built-in or loaded before the test
> starts, kci_test_ipsec_offload doesn't remove the netdevsim device it
> created during the test.
>
> Fixes: e05b2d141fef ("netdevsim: move netdev creation/destruction to dev probe")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] selftests: rtnetlink: remove netdevsim device after ipsec offload test
2023-06-22 21:03 [PATCH net] selftests: rtnetlink: remove netdevsim device after ipsec offload test Sabrina Dubroca
2023-06-23 6:53 ` Simon Horman
@ 2023-06-23 7:46 ` Jiri Pirko
2023-06-24 22:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Pirko @ 2023-06-23 7:46 UTC (permalink / raw)
To: Sabrina Dubroca; +Cc: netdev, Shuah Khan, linux-kselftest
Thu, Jun 22, 2023 at 11:03:34PM CEST, sd@queasysnail.net wrote:
>On systems where netdevsim is built-in or loaded before the test
>starts, kci_test_ipsec_offload doesn't remove the netdevsim device it
>created during the test.
>
>Fixes: e05b2d141fef ("netdevsim: move netdev creation/destruction to dev probe")
>Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] selftests: rtnetlink: remove netdevsim device after ipsec offload test
2023-06-22 21:03 [PATCH net] selftests: rtnetlink: remove netdevsim device after ipsec offload test Sabrina Dubroca
2023-06-23 6:53 ` Simon Horman
2023-06-23 7:46 ` Jiri Pirko
@ 2023-06-24 22:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-24 22:20 UTC (permalink / raw)
To: Sabrina Dubroca; +Cc: netdev, jiri, shuah, linux-kselftest
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 22 Jun 2023 23:03:34 +0200 you wrote:
> On systems where netdevsim is built-in or loaded before the test
> starts, kci_test_ipsec_offload doesn't remove the netdevsim device it
> created during the test.
>
> Fixes: e05b2d141fef ("netdevsim: move netdev creation/destruction to dev probe")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
>
> [...]
Here is the summary with links:
- [net] selftests: rtnetlink: remove netdevsim device after ipsec offload test
https://git.kernel.org/netdev/net/c/5f789f103671
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-24 22:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-22 21:03 [PATCH net] selftests: rtnetlink: remove netdevsim device after ipsec offload test Sabrina Dubroca
2023-06-23 6:53 ` Simon Horman
2023-06-23 7:46 ` Jiri Pirko
2023-06-24 22:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).