From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 966C2BA29 for ; Mon, 26 Jun 2023 15:17:44 +0000 (UTC) Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EC3BE191; Mon, 26 Jun 2023 08:17:42 -0700 (PDT) Date: Mon, 26 Jun 2023 17:17:40 +0200 From: Pablo Neira Ayuso To: Randy Dunlap Cc: netdev@vger.kernel.org, Florian Westphal , Jozsef Kadlecsik , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH net-next] linux/netfilter.h: fix kernel-doc warnings Message-ID: References: <20230623061101.32513-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230623061101.32513-1-rdunlap@infradead.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Thu, Jun 22, 2023 at 11:11:01PM -0700, Randy Dunlap wrote: > kernel-doc does not support DECLARE_PER_CPU(), so don't mark it with > kernel-doc notation. > > One comment block is not kernel-doc notation, so just use > "/*" to begin the comment. > > Quietens these warnings: > > netfilter.h:493: warning: Function parameter or member 'bool' not described in 'DECLARE_PER_CPU' > netfilter.h:493: warning: Function parameter or member 'nf_skb_duplicated' not described in 'DECLARE_PER_CPU' > netfilter.h:493: warning: expecting prototype for nf_skb_duplicated(). Prototype was for DECLARE_PER_CPU() instead > netfilter.h:496: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > * Contains bitmask of ctnetlink event subscribers, if any. Applied to nf.git, thanks