From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7210F6FC0 for ; Thu, 13 Jul 2023 08:06:32 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D93BF2D58 for ; Thu, 13 Jul 2023 01:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=osGQCoFsA115itAF/3BRNwmc8iArLh4T0+7xb0MN6Bo=; b=rZaFP+SEDm2h0rjMfKJOM3RZHB L1PP/QfKYymasVkkRcpz8rGmopiwUQTpQCr8YYphU6FIoTmPnxcHJtym08gVTztXdyQl9swjK7oBZ lTw4E8tCaPHpJOnjcAkfXO2wJIJKsJ4GaIb1zFizIjhf21xTXeCS0PvdbABWSUwYu739tivLfZAkb J/VRdd2LTLbhReE5tbp+HJPJ5fCxy4V8oVNGb+o9OjmIVvUKCIcsmffHke86pO8Bh+VGDHsI/KoCi ocwFp0dy0uJZDRugP6vOesiO2ciAJwc/X08kcq2+B9hlaPPbOPW/46BY81NQEidTd7Ol3rtc6tCbA XqHtfclA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41290) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qJrL8-0005zI-14; Thu, 13 Jul 2023 09:06:18 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qJrL4-0005xc-La; Thu, 13 Jul 2023 09:06:14 +0100 Date: Thu, 13 Jul 2023 09:06:14 +0100 From: "Russell King (Oracle)" To: Feiyang Chen Cc: andrew@lunn.ch, hkallweit1@gmail.com, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, chenhuacai@loongson.cn, dongbiao@loongson.cn, loongson-kernel@lists.loongnix.cn, netdev@vger.kernel.org, loongarch@lists.linux.dev, chris.chenfeiyang@gmail.com Subject: Re: [RFC PATCH 10/10] net: stmmac: dwmac-loongson: Add GNET support Message-ID: References: <98b53d15bb983c309f79acf9619b88ea4fbb8f14.1689215889.git.chenfeiyang@loongson.cn> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <98b53d15bb983c309f79acf9619b88ea4fbb8f14.1689215889.git.chenfeiyang@loongson.cn> Sender: Russell King (Oracle) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Thu, Jul 13, 2023 at 10:49:38AM +0800, Feiyang Chen wrote: > Add GNET support. Use the fix_mac_speed() callback to workaround > issues with the Loongson PHY. It would be good to document what those issue(s) are, and if they are a PHY issue, why they need to be resolved in a MAC driver rather than using the PHY driver's link_change_notify(). Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!