* [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM [not found] <20230707135852.24292-1-bhe@redhat.com> @ 2023-07-07 13:58 ` Baoquan He 2023-07-11 17:17 ` Simon Horman 0 siblings, 1 reply; 3+ messages in thread From: Baoquan He @ 2023-07-07 13:58 UTC (permalink / raw) To: linux-kernel Cc: akpm, linux-mm, schnelle, vkoul, eli.billauer, arnd, gregkh, derek.kiernan, dragan.cvetic, linux, Jonathan.Cameron, linus.walleij, tsbogend, joyce.ooi, davem, edumazet, kuba, pabeni, tglx, maz, mturquette, sboyd, robh+dt, frowand.list, Baoquan He, kernel test robot, netdev On s390 systems (aka mainframes), it has classic channel devices for networking and permanent storage that are currently even more common than PCI devices. Hence it could have a fully functional s390 kernel with CONFIG_PCI=n, then the relevant iomem mapping functions [including ioremap(), devm_ioremap(), etc.] are not available. Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built to cause below compiling error if PCI is unset: ------ ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined! ------ Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ Signed-off-by: Baoquan He <bhe@redhat.com> Cc: Joyce Ooi <joyce.ooi@intel.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Cc: netdev@vger.kernel.org --- drivers/net/ethernet/altera/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/altera/Kconfig b/drivers/net/ethernet/altera/Kconfig index 17985319088c..4ef819a9a1ad 100644 --- a/drivers/net/ethernet/altera/Kconfig +++ b/drivers/net/ethernet/altera/Kconfig @@ -2,6 +2,7 @@ config ALTERA_TSE tristate "Altera Triple-Speed Ethernet MAC support" depends on HAS_DMA + depends on HAS_IOMEM select PHYLIB select PHYLINK select PCS_LYNX -- 2.34.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM 2023-07-07 13:58 ` [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM Baoquan He @ 2023-07-11 17:17 ` Simon Horman 2023-07-12 0:46 ` Baoquan He 0 siblings, 1 reply; 3+ messages in thread From: Simon Horman @ 2023-07-11 17:17 UTC (permalink / raw) To: Baoquan He Cc: linux-kernel, akpm, linux-mm, schnelle, vkoul, eli.billauer, arnd, gregkh, derek.kiernan, dragan.cvetic, linux, Jonathan.Cameron, linus.walleij, tsbogend, joyce.ooi, davem, edumazet, kuba, pabeni, tglx, maz, mturquette, sboyd, robh+dt, frowand.list, kernel test robot, netdev On Fri, Jul 07, 2023 at 09:58:49PM +0800, Baoquan He wrote: > On s390 systems (aka mainframes), it has classic channel devices for > networking and permanent storage that are currently even more common > than PCI devices. Hence it could have a fully functional s390 kernel > with CONFIG_PCI=n, then the relevant iomem mapping functions > [including ioremap(), devm_ioremap(), etc.] are not available. > > Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built > to cause below compiling error if PCI is unset: > > ------ > ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined! > ------ > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ > Signed-off-by: Baoquan He <bhe@redhat.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Tested-by: Simon Horman <simon.horman@corigine.com> # build-tested I wonder if this should also have: Fixes: ed33ef648964 ("Altera TSE: Add Altera Ethernet Driver Makefile and Kconfig") ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM 2023-07-11 17:17 ` Simon Horman @ 2023-07-12 0:46 ` Baoquan He 0 siblings, 0 replies; 3+ messages in thread From: Baoquan He @ 2023-07-12 0:46 UTC (permalink / raw) To: Simon Horman Cc: linux-kernel, akpm, linux-mm, schnelle, vkoul, eli.billauer, arnd, gregkh, derek.kiernan, dragan.cvetic, linux, Jonathan.Cameron, linus.walleij, tsbogend, joyce.ooi, davem, edumazet, kuba, pabeni, tglx, maz, mturquette, sboyd, robh+dt, frowand.list, kernel test robot, netdev On 07/11/23 at 06:17pm, Simon Horman wrote: > On Fri, Jul 07, 2023 at 09:58:49PM +0800, Baoquan He wrote: > > On s390 systems (aka mainframes), it has classic channel devices for > > networking and permanent storage that are currently even more common > > than PCI devices. Hence it could have a fully functional s390 kernel > > with CONFIG_PCI=n, then the relevant iomem mapping functions > > [including ioremap(), devm_ioremap(), etc.] are not available. > > > > Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built > > to cause below compiling error if PCI is unset: > > > > ------ > > ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined! > > ------ > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ > > Signed-off-by: Baoquan He <bhe@redhat.com> > > > Reviewed-by: Simon Horman <simon.horman@corigine.com> > Tested-by: Simon Horman <simon.horman@corigine.com> # build-tested Thanks, Simon. > > I wonder if this should also have: > > Fixes: ed33ef648964 ("Altera TSE: Add Altera Ethernet Driver Makefile and Kconfig") Agree, it's worth having Fixes tag. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-12 0:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230707135852.24292-1-bhe@redhat.com>
2023-07-07 13:58 ` [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM Baoquan He
2023-07-11 17:17 ` Simon Horman
2023-07-12 0:46 ` Baoquan He
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).