From: Ido Schimmel <idosch@idosch.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Harry Coin <hcoin@quietfountain.com>
Subject: Re: [PATCH v2 net] bridge: Add extack warning when enabling STP in netns.
Date: Wed, 12 Jul 2023 19:14:46 +0300 [thread overview]
Message-ID: <ZK7RdhQ6fBkOY/F+@shredder> (raw)
In-Reply-To: <20230712154449.6093-1-kuniyu@amazon.com>
On Wed, Jul 12, 2023 at 08:44:49AM -0700, Kuniyuki Iwashima wrote:
> When we create an L2 loop on a bridge in netns, we will see packets storm
> even if STP is enabled.
>
> # unshare -n
> # ip link add br0 type bridge
> # ip link add veth0 type veth peer name veth1
> # ip link set veth0 master br0 up
> # ip link set veth1 master br0 up
> # ip link set br0 type bridge stp_state 1
> # ip link set br0 up
> # sleep 30
> # ip -s link show br0
> 2: br0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
> link/ether b6:61:98:1c:1c:b5 brd ff:ff:ff:ff:ff:ff
> RX: bytes packets errors dropped missed mcast
> 956553768 12861249 0 0 0 12861249 <-. Keep
> TX: bytes packets errors dropped carrier collsns | increasing
> 1027834 11951 0 0 0 0 <-' rapidly
>
> This is because llc_rcv() drops all packets in non-root netns and BPDU
> is dropped.
>
> Let's add extack warning when enabling STP in netns.
>
> # unshare -n
> # ip link add br0 type bridge
> # ip link set br0 type bridge stp_state 1
> Warning: bridge: STP does not work in non-root netns.
>
> Note this commit will be reverted later when we namespacify the whole LLC
> infra.
>
> Fixes: e730c15519d0 ("[NET]: Make packet reception network namespace safe")
> Suggested-by: Harry Coin <hcoin@quietfountain.com>
> Link: https://lore.kernel.org/netdev/0f531295-e289-022d-5add-5ceffa0df9bc@quietfountain.com/
> Suggested-by: Ido Schimmel <idosch@idosch.org>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2023-07-12 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 15:44 [PATCH v2 net] bridge: Add extack warning when enabling STP in netns Kuniyuki Iwashima
2023-07-12 15:46 ` Nikolay Aleksandrov
2023-07-12 16:14 ` Ido Schimmel [this message]
2023-07-14 7:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK7RdhQ6fBkOY/F+@shredder \
--to=idosch@idosch.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=hcoin@quietfountain.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox