* [PATCH net] s390/qeth: Fix vipa deletion
@ 2023-07-04 14:41 Alexandra Winter
2023-07-04 20:43 ` Simon Horman
2023-07-05 9:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Alexandra Winter @ 2023-07-04 14:41 UTC (permalink / raw)
To: David Miller, Jakub Kicinski, Paolo Abeni, Eric Dumazet
Cc: netdev, linux-s390, Heiko Carstens, Thorsten Winkler,
Alexandra Winter, Wenjia Zhang
From: Thorsten Winkler <twinkler@linux.ibm.com>
Change boolean parameter of function "qeth_l3_vipa_store" inside the
"qeth_l3_dev_vipa_del4_store" function from "true" to "false" because
"true" is used for adding a virtual ip address and "false" for deleting.
Fixes: 2390166a6b45 ("s390/qeth: clean up L3 sysfs code")
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
Signed-off-by: Thorsten Winkler <twinkler@linux.ibm.com>
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
---
drivers/s390/net/qeth_l3_sys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/net/qeth_l3_sys.c b/drivers/s390/net/qeth_l3_sys.c
index 9f90a860ca2c..a6b64228ead2 100644
--- a/drivers/s390/net/qeth_l3_sys.c
+++ b/drivers/s390/net/qeth_l3_sys.c
@@ -625,7 +625,7 @@ static QETH_DEVICE_ATTR(vipa_add4, add4, 0644,
static ssize_t qeth_l3_dev_vipa_del4_store(struct device *dev,
struct device_attribute *attr, const char *buf, size_t count)
{
- return qeth_l3_vipa_store(dev, buf, true, count, QETH_PROT_IPV4);
+ return qeth_l3_vipa_store(dev, buf, false, count, QETH_PROT_IPV4);
}
static QETH_DEVICE_ATTR(vipa_del4, del4, 0200, NULL,
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] s390/qeth: Fix vipa deletion
2023-07-04 14:41 [PATCH net] s390/qeth: Fix vipa deletion Alexandra Winter
@ 2023-07-04 20:43 ` Simon Horman
2023-07-05 9:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-07-04 20:43 UTC (permalink / raw)
To: Alexandra Winter
Cc: David Miller, Jakub Kicinski, Paolo Abeni, Eric Dumazet, netdev,
linux-s390, Heiko Carstens, Thorsten Winkler, Wenjia Zhang
On Tue, Jul 04, 2023 at 04:41:21PM +0200, Alexandra Winter wrote:
> From: Thorsten Winkler <twinkler@linux.ibm.com>
>
> Change boolean parameter of function "qeth_l3_vipa_store" inside the
> "qeth_l3_dev_vipa_del4_store" function from "true" to "false" because
> "true" is used for adding a virtual ip address and "false" for deleting.
>
> Fixes: 2390166a6b45 ("s390/qeth: clean up L3 sysfs code")
>
nit: no blank line here.
> Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
> Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
> Signed-off-by: Thorsten Winkler <twinkler@linux.ibm.com>
> Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] s390/qeth: Fix vipa deletion
2023-07-04 14:41 [PATCH net] s390/qeth: Fix vipa deletion Alexandra Winter
2023-07-04 20:43 ` Simon Horman
@ 2023-07-05 9:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-05 9:50 UTC (permalink / raw)
To: Alexandra Winter
Cc: davem, kuba, pabeni, edumazet, netdev, linux-s390, hca, twinkler,
wenjia
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Tue, 4 Jul 2023 16:41:21 +0200 you wrote:
> From: Thorsten Winkler <twinkler@linux.ibm.com>
>
> Change boolean parameter of function "qeth_l3_vipa_store" inside the
> "qeth_l3_dev_vipa_del4_store" function from "true" to "false" because
> "true" is used for adding a virtual ip address and "false" for deleting.
>
> Fixes: 2390166a6b45 ("s390/qeth: clean up L3 sysfs code")
>
> [...]
Here is the summary with links:
- [net] s390/qeth: Fix vipa deletion
https://git.kernel.org/netdev/net/c/80de809bd35e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-05 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-04 14:41 [PATCH net] s390/qeth: Fix vipa deletion Alexandra Winter
2023-07-04 20:43 ` Simon Horman
2023-07-05 9:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).