* [PATCH net] net: mvneta: fix txq_map in case of txq_number==1
@ 2023-07-05 5:37 Klaus Kudielka
2023-07-05 18:38 ` Michal Kubiak
2023-07-06 8:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Klaus Kudielka @ 2023-07-05 5:37 UTC (permalink / raw)
To: Thomas Petazzoni
Cc: Klaus Kudielka, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Gregory CLEMENT, netdev, linux-kernel
If we boot with mvneta.txq_number=1, the txq_map is set incorrectly:
MVNETA_CPU_TXQ_ACCESS(1) refers to TX queue 1, but only TX queue 0 is
initialized. Fix this.
Fixes: 50bf8cb6fc9c ("net: mvneta: Configure XPS support")
Signed-off-by: Klaus Kudielka <klaus.kudielka@gmail.com>
---
drivers/net/ethernet/marvell/mvneta.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 2cad76d0a50e..4401fad31fb9 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -1505,7 +1505,7 @@ static void mvneta_defaults_set(struct mvneta_port *pp)
*/
if (txq_number == 1)
txq_map = (cpu == pp->rxq_def) ?
- MVNETA_CPU_TXQ_ACCESS(1) : 0;
+ MVNETA_CPU_TXQ_ACCESS(0) : 0;
} else {
txq_map = MVNETA_CPU_TXQ_ACCESS_ALL_MASK;
@@ -4295,7 +4295,7 @@ static void mvneta_percpu_elect(struct mvneta_port *pp)
*/
if (txq_number == 1)
txq_map = (cpu == elected_cpu) ?
- MVNETA_CPU_TXQ_ACCESS(1) : 0;
+ MVNETA_CPU_TXQ_ACCESS(0) : 0;
else
txq_map = mvreg_read(pp, MVNETA_CPU_MAP(cpu)) &
MVNETA_CPU_TXQ_ACCESS_ALL_MASK;
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: mvneta: fix txq_map in case of txq_number==1
2023-07-05 5:37 [PATCH net] net: mvneta: fix txq_map in case of txq_number==1 Klaus Kudielka
@ 2023-07-05 18:38 ` Michal Kubiak
2023-07-06 8:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Michal Kubiak @ 2023-07-05 18:38 UTC (permalink / raw)
To: Klaus Kudielka
Cc: Thomas Petazzoni, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Gregory CLEMENT, netdev, linux-kernel
On Wed, Jul 05, 2023 at 07:37:12AM +0200, Klaus Kudielka wrote:
> If we boot with mvneta.txq_number=1, the txq_map is set incorrectly:
> MVNETA_CPU_TXQ_ACCESS(1) refers to TX queue 1, but only TX queue 0 is
> initialized. Fix this.
>
> Fixes: 50bf8cb6fc9c ("net: mvneta: Configure XPS support")
> Signed-off-by: Klaus Kudielka <klaus.kudielka@gmail.com>
LGTM
Thanks,
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: mvneta: fix txq_map in case of txq_number==1
2023-07-05 5:37 [PATCH net] net: mvneta: fix txq_map in case of txq_number==1 Klaus Kudielka
2023-07-05 18:38 ` Michal Kubiak
@ 2023-07-06 8:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-06 8:50 UTC (permalink / raw)
To: Klaus Kudielka
Cc: thomas.petazzoni, davem, edumazet, kuba, pabeni, gregory.clement,
netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 5 Jul 2023 07:37:12 +0200 you wrote:
> If we boot with mvneta.txq_number=1, the txq_map is set incorrectly:
> MVNETA_CPU_TXQ_ACCESS(1) refers to TX queue 1, but only TX queue 0 is
> initialized. Fix this.
>
> Fixes: 50bf8cb6fc9c ("net: mvneta: Configure XPS support")
> Signed-off-by: Klaus Kudielka <klaus.kudielka@gmail.com>
>
> [...]
Here is the summary with links:
- [net] net: mvneta: fix txq_map in case of txq_number==1
https://git.kernel.org/netdev/net/c/21327f81db63
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-06 8:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-05 5:37 [PATCH net] net: mvneta: fix txq_map in case of txq_number==1 Klaus Kudielka
2023-07-05 18:38 ` Michal Kubiak
2023-07-06 8:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).