From: Michal Kubiak <michal.kubiak@intel.com>
To: Junfeng Guo <junfeng.guo@intel.com>
Cc: <netdev@vger.kernel.org>, <jeroendb@google.com>,
<pkaligineedi@google.com>, <shailend@google.com>,
<haiyue.wang@intel.com>, <kuba@kernel.org>,
<awogbemila@google.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <yangchun@google.com>, <edumazet@google.com>,
<csully@google.com>
Subject: Re: [PATCH net] gve: unify driver name usage
Date: Fri, 7 Jul 2023 20:26:45 +0200 [thread overview]
Message-ID: <ZKhY5Y0C5ySmkp1w@localhost.localdomain> (raw)
In-Reply-To: <20230707103710.3946651-1-junfeng.guo@intel.com>
On Fri, Jul 07, 2023 at 06:37:10PM +0800, Junfeng Guo wrote:
> Current codebase contained the usage of two different names for this
> driver (i.e., `gvnic` and `gve`), which is quite unfriendly for users
> to use, especially when trying to bind or unbind the driver manually.
> The corresponding kernel module is registered with the name of `gve`.
> It's more reasonable to align the name of the driver with the module.
>
> Fixes: 893ce44df565 ("gve: Add basic driver framework for Compute Engine Virtual NIC")
> Cc: csully@google.com
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> ---
>
The patch makes the driver strings much more consistent.
Looks good to me.
Thanks,
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
next prev parent reply other threads:[~2023-07-07 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 10:37 [PATCH net] gve: unify driver name usage Junfeng Guo
2023-07-07 18:26 ` Michal Kubiak [this message]
2023-07-08 2:50 ` Guo, Junfeng
2023-07-07 22:20 ` Jakub Kicinski
2023-07-08 2:58 ` Guo, Junfeng
2023-07-08 3:14 ` [PATCH net v2] " Junfeng Guo
2023-07-08 21:20 ` Andrew Lunn
2023-07-10 7:40 ` patchwork-bot+netdevbpf
2023-07-11 13:13 ` [PATCH net] " Alexander Lobakin
2023-07-11 17:24 ` Wang, Haiyue
2023-07-12 16:55 ` Alexander Lobakin
2023-07-12 17:44 ` Wang, Haiyue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKhY5Y0C5ySmkp1w@localhost.localdomain \
--to=michal.kubiak@intel.com \
--cc=awogbemila@google.com \
--cc=csully@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haiyue.wang@intel.com \
--cc=jeroendb@google.com \
--cc=junfeng.guo@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=shailend@google.com \
--cc=yangchun@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).