From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2B2810792 for ; Mon, 10 Jul 2023 12:10:06 +0000 (UTC) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FD86F9 for ; Mon, 10 Jul 2023 05:10:01 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3fbfcc6daa9so33544105e9.3 for ; Mon, 10 Jul 2023 05:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1688991000; x=1691583000; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H+JMKDNGrwhDe4HBcYBuaXlqFjTwAt1vMreVme3OFY8=; b=MD2tvasVfOO4Nxy8SwUpBNEofYhK1a76YN7YTyJ6XCk4qvq1spePWJ5U2HolrrDdOT pzotR5LDEF25B41YlghYLyVcJkdw7vYJckcNJXxzoVzx8DbQ+6hEFFhdUj6XuU5/JwTS de7OJ/wZbyomxDR6RlVAoOvpDOADSoZgTnFR2HGAnnoWaFFoubJOc/2oATJfKeVSTYBJ xp2eDZ1l4OxeIVU/voQMubWmuIrIVwG/CaH7gXvloqVZatO1QXMFsWy7LlP8TddCh4qu 5Do8+o8pothhSJMw+0Mm75HDNlA3gJgbKA3Vb5t+JO+ihvcYFSzAincJ4KCt7QFMv+p/ CNRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688991000; x=1691583000; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H+JMKDNGrwhDe4HBcYBuaXlqFjTwAt1vMreVme3OFY8=; b=leraJnyX39vxWYydW1/donUOWrQsjGRFS752TZ+M3CZ7m1SuKv3NpOPIB6zrz8oDim HhdZyRsmskxjqmBSWOf1+Hl5ZQ3S3KLpnhMvlIctlbUoV0TWLSjhEwU8ejv2UxScv7Ar LQN05TL5Ybj/9XfwqdOuu94axbyuTNsyL0NDHgMJyasx9BFn8yxHQ8ohhnVD/11MyQKv VHrgPEBbS11qftf1zjaz328wfPjjxYin/shWPi0N0LnMTz8j9XBSyzzRZZRV9CZ+mPgs /IusQcknPa6DL9kTZSx2M3EX6kyZYmsD8Mvk/DUBHVbvzH5npBWx+tZgMmoGnWNIaBkX OXkw== X-Gm-Message-State: ABy/qLbf1Mf0Yi5ZxKFIVtvZGq7zufp5eli+0DnAKx4ejczPjZUfOYrC PC5OcZVwcYAw9sV66+mYErw+7A== X-Google-Smtp-Source: APBJJlG6iRHARThiiqxbJc+oH1dUx5jylRNEM8Djmjy4H8sNg1Su/SyUt7SEHMg58iXBXU/0NBUMLA== X-Received: by 2002:a05:600c:2209:b0:3fc:b86:d3fa with SMTP id z9-20020a05600c220900b003fc0b86d3famr4756381wml.1.1688990999804; Mon, 10 Jul 2023 05:09:59 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id z13-20020a7bc7cd000000b003fc0062f0f8sm9128556wmk.9.2023.07.10.05.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 05:09:59 -0700 (PDT) Date: Mon, 10 Jul 2023 14:09:57 +0200 From: Jiri Pirko To: "Kubalewski, Arkadiusz" Cc: "kuba@kernel.org" , "vadfed@meta.com" , "jonathan.lemon@gmail.com" , "pabeni@redhat.com" , "corbet@lwn.net" , "davem@davemloft.net" , "edumazet@google.com" , "vadfed@fb.com" , "Brandeburg, Jesse" , "Nguyen, Anthony L" , "M, Saeed" , "leon@kernel.org" , "richardcochran@gmail.com" , "sj@kernel.org" , "javierm@redhat.com" , "ricardo.canuelo@collabora.com" , "mst@redhat.com" , "tzimmermann@suse.de" , "Michalik, Michal" , "gregkh@linuxfoundation.org" , "jacek.lawrynowicz@linux.intel.com" , "airlied@redhat.com" , "ogabbay@kernel.org" , "arnd@arndb.de" , "nipun.gupta@amd.com" , "axboe@kernel.dk" , "linux@zary.sk" , "masahiroy@kernel.org" , "benjamin.tissoires@redhat.com" , "geert+renesas@glider.be" , "Olech, Milena" , "kuniyu@amazon.com" , "liuhangbin@gmail.com" , "hkallweit1@gmail.com" , "andy.ren@getcruise.com" , "razor@blackwall.org" , "idosch@nvidia.com" , "lucien.xin@gmail.com" , "nicolas.dichtel@6wind.com" , "phil@nwl.cc" , "claudiajkang@gmail.com" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "linux-rdma@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "linux-clk@vger.kernel.org" , "vadim.fedorenko@linux.dev" Subject: Re: [RFC PATCH v9 00/10] Create common DPLL configuration API Message-ID: References: <20230623123820.42850-1-arkadiusz.kubalewski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Mon, Jul 10, 2023 at 12:07:30PM CEST, arkadiusz.kubalewski@intel.com wrote: >>From: Jiri Pirko >>Sent: Wednesday, June 28, 2023 1:16 PM >>Wed, Jun 28, 2023 at 11:15:11AM CEST, arkadiusz.kubalewski@intel.com wrote: >>>>From: Jiri Pirko >>>>Sent: Tuesday, June 27, 2023 12:18 PM >>>> >>>>Fri, Jun 23, 2023 at 02:38:10PM CEST, arkadiusz.kubalewski@intel.com >>>>wrote: >>>> >>>>>v8 -> v9: >>>> >>>>Could you please address all the unresolved issues from v8 and send v10? >>>>I'm not reviewing this one. >>>> >>>>Thanks! >>> >>>Sure, will do, but first missing to-do/discuss list: >>>1) remove mode_set as not used by any driver > >I have implemented in ice (also added back the DPLL_MODE_FREERUN). Uh :/ Why exactly is it needed in this initial submission? > >>>2) remove "no-added-value" static functions descriptions in >>> dpll_core/dpll_netlink > >Removed. > >>>3) merge patches [ 03/10, 04/10, 05/10 ] into patches that are compiling >>> after each patch apply > >Hope Vadim will decide on this, the thing is merging in two patches >doesn't make much sense as there won't be any linking until both patches >are there, so most sense it would be if 3 are merged into one, but >then we will be back to one big blob patch issue. > >>>4) remove function return values descriptions/lists > >Fixed. > >>>5) Fix patch [05/10]: >>> - status Supported >>> - additional maintainers >>> - remove callback: >>> int (*source_pin_idx_get)(...) from `struct dpll_device_ops` >>>6) Fix patch [08/10]: rethink ice mutex locking scheme > >Fixed. > >>>7) Fix patch [09/10]: multiple comments on >>>https://lore.kernel.org/netdev/ZIQu+%2Fo4J0ZBspVg@nanopsycho/#t >>>8) add PPS DPLL phase offset to the netlink get-device API >>> > >Added few things on this matter >- 1 dpll level attribute: > - phase-shift - measuring the phase difference between dpll input > and it's output >- 1 dpll-pin tuple level attribute: > - pin-phase-adjust - set/get phase adjust of a pin on a dpll >- 2 pin level attributes: > - pin-phase-adjust-min - provide user with min value that can be set > - pin-phase-adjust-max - provide user with max value that can be set >- a constant: > - DPLL_PHASE_SHIFT_DIVIDER similar to DPLL_TEMP_DIVIDER for producing > fraction value of measured DPLL_A_PHASE_SHIFT Again, why do we need this in this initial submission? Why it can't be a follow-up patchset to extend this? This way we never converge :/ Please focus on what we have now and bring it in. Let the extensions to be addressed later on, please. >- implemented in dpll netlink and in ice > >> >>You are missing removal of pin->prop.package_label = dev_name(dev); in >>ice. >> > >I didn't touch it, as we still need to discuss it, Jakub didn't respond >on v8 thread. >I don't see why we shall not name it the way. This is most meaningful >label for those pins for the user right now. This is not meaningful, at all. dev_name() changes upon which pci slot you plug the card into. package_label should be an actual label on a silicon package. Why you think this two are related in aby way, makes me really wonder. Could you elaborate the meaningfulness of this? > >Thank you! >Arkadiusz > >> >>>Thank you! >>>Arkadiusz