From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F3A1200BA for ; Tue, 25 Jul 2023 15:24:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BF6FC433C8; Tue, 25 Jul 2023 15:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690298655; bh=+MfVjB/wjdps2ovrI3oDMNYk7WQRpUGIc0K5gkQDUIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gPq8eVoFZT6gk5cJ4o3gDvI8uBvnJ6TORQWk/GOfQzPjuE9rZvceL+zOQYNP7fUh2 fNDsDS/AaOFWe1KSsuQQcW39LJyqTn240qTgogqgJNy6jkTj/jdc1o+gVHiOwqkANA oDc6Eabr7/YJw5+lNZA4pDAO/S/bI4VYTouqQBJ2d209+JwGdpicCKYueCP2ykjzMK zPTnnFqMHLVkXymEQNIu/9MjJCK09GEpowCDOMtrIxDAYGpqqz+hp6rwa7VoK0Ycul 7ZImFTWJ3mCi329bhEx2C9ALC9ntpS47htqEfnmNa3U4GjX1v9rq0JEA7QGb4e//9T E44CiymAS7qMw== Date: Tue, 25 Jul 2023 23:12:38 +0800 From: Jisheng Zhang To: Rob Herring Cc: Conor Dooley , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next 07/10] dt-bindings: net: snps,dwmac: add safety irq support Message-ID: References: <20230723161029.1345-1-jszhang@kernel.org> <20230723161029.1345-8-jszhang@kernel.org> <20230724-cleat-tricolor-e455afa60b14@spud> <20230724232624.GA1112850-robh@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230724232624.GA1112850-robh@kernel.org> On Mon, Jul 24, 2023 at 05:26:24PM -0600, Rob Herring wrote: > On Mon, Jul 24, 2023 at 06:23:13PM +0100, Conor Dooley wrote: > > On Mon, Jul 24, 2023 at 12:10:26AM +0800, Jisheng Zhang wrote: > > > The snps dwmac IP support safety features, and those Safety Feature > > > Correctible Error and Uncorrectible Error irqs may be separate irqs. > > > > > > Signed-off-by: Jisheng Zhang > > > --- > > > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > index ddf9522a5dc2..bb80ca205d26 100644 > > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > > > @@ -107,6 +107,8 @@ properties: > > > - description: Combined signal for various interrupt events > > > - description: The interrupt to manage the remote wake-up packet detection > > > - description: The interrupt that occurs when Rx exits the LPI state > > > + - description: The interrupt that occurs when Safety Feature Correctible Errors happen > > > + - description: The interrupt that occurs when Safety Feature Uncorrectible Errors happen > > > > > > interrupt-names: > > > minItems: 1 > > > @@ -114,6 +116,8 @@ properties: > > > - const: macirq > > > - enum: [eth_wake_irq, eth_lpi] > > > - const: eth_lpi > > > + - const: sfty_ce_irq > > > + - const: sfty_ue_irq > > > > Putting _irq in an interrupt name seems rather redundant to me although, > > clearly not the first time for it here. > > It's already inconsistent, so don't follow that pattern. Drop '_irq'. Thanks for the suggestion, will wait a bit to get more feedbacks before sending out v2. > > > > > Acked-by: Conor Dooley > > > > Thanks, > > Conor. > >