From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02B4015AEF for ; Tue, 25 Jul 2023 10:12:53 +0000 (UTC) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 531C510E3; Tue, 25 Jul 2023 03:12:52 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id EA5DF32008FB; Tue, 25 Jul 2023 06:12:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 25 Jul 2023 06:12:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1690279970; x=1690366370; bh=xgUVqqNdgbniF Ku43r5PV8GdNxqPVdClT1x0fcn2Eiw=; b=zS/A2pyjZnF4kvWcirBt5OlRqnuVY t+BE+RRUQvF2Ruvx7K72DOWdQddydkr8HOV45r0zSsPsLhzK5IZopyDsmw5H3vHK 2Oz+DX/OF/5SQGBHQisMgv1FJGGq1V9TPInEKhDdBYV0Jz3Zbu+vCcBKoEFCKN/c L1K1ARsDWqW89K4CqdUTDnY/b8da4BHIp/2p0C0Ahm5t1YszMZQtYlNOLkbhNWBZ E1+qXZxGJG94Ln1wpIcicgc8czpDyFHZOacNlxWEKZ0QFlE9RJ0+PGt7UfG6HGT9 hoVca3T9YpHkXP5vdoXxHOLMvnH/puK//qRB10Ahqf8TSq7sL+sfS1CpQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedriedtgddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedvudefveekheeugeeftddvveefgfduieefudeifefgleekheegleegjeejgeeg hfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiug hoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Jul 2023 06:12:49 -0400 (EDT) Date: Tue, 25 Jul 2023 13:12:46 +0300 From: Ido Schimmel To: Ratheesh Kannoth Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Subject: Re: [PATCH net-next] flow_dissector: Add IPSEC dissectors Message-ID: References: <20230725032451.505189-1-rkannoth@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725032451.505189-1-rkannoth@marvell.com> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, Jul 25, 2023 at 08:54:51AM +0530, Ratheesh Kannoth wrote: > Support for dissecting IPSEC field SPI (which is > 32bits in size) for ESP and AH packets. > > This implementation does not support NAT-T > (encapsulation of ESP packets over UDP). > > Signed-off-by: Ratheesh Kannoth > --- > include/net/flow_dissector.h | 9 ++++++ > include/net/flow_offload.h | 6 ++++ > include/uapi/linux/pkt_cls.h | 3 ++ > net/core/flow_dissector.c | 53 +++++++++++++++++++++++++++++++++++- > net/core/flow_offload.c | 7 +++++ > net/sched/cls_flower.c | 18 ++++++++++++ Please split flow dissector and flower changes into separate patches. Also, you can't add the flow offload bits without a corresponding driver change. Nobody calls the exported flow_rule_match_ipsec() function. [...] > diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h > index 7865f5a9885b..a90b0e3d351f 100644 > --- a/include/uapi/linux/pkt_cls.h > +++ b/include/uapi/linux/pkt_cls.h > @@ -594,6 +594,9 @@ enum { > > TCA_FLOWER_KEY_L2TPV3_SID, /* be32 */ > > + TCA_FLOWER_KEY_SPI, /* be32 */ > + TCA_FLOWER_KEY_SPI_MASK, /* be32 */ > + This will break existing user space on new kernels. New attributes must be added at the end. > TCA_FLOWER_L2_MISS, /* u8 */ > > TCA_FLOWER_KEY_CFM, /* nested */