From: Hangbin Liu <liuhangbin@gmail.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, Liang Li <liali@redhat.com>,
Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net 2/2] team: reset team's flags when down link is P2P device
Date: Fri, 14 Jul 2023 16:10:00 +0800 [thread overview]
Message-ID: <ZLEC2OQGS/gFsfKI@Laptop-X1> (raw)
In-Reply-To: <076ccae1-22e7-d7ab-1143-41a7a6f73b67@blackwall.org>
On Fri, Jul 14, 2023 at 09:52:03AM +0300, Nikolay Aleksandrov wrote:
> > + if (port_dev->flags & IFF_POINTOPOINT)
> > + dev->flags &= ~(IFF_BROADCAST | IFF_MULTICAST);
> > + dev->flags |= (IFF_POINTOPOINT | IFF_NOARP);
>
> here too, looks like missing {}
Yes, you are right. I forgot to add the {}. When do testing before post the
patch. I just checked adding gre device to bonding and didn't check adding
ethernet interface...
Thanks for your review.
Hangbin
prev parent reply other threads:[~2023-07-14 8:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 2:51 [PATCH net 0/2] Fix up dev flags when add P2P down link Hangbin Liu
2023-07-14 2:52 ` [PATCH net 1/2] bonding: reset bond's flags when down link is P2P device Hangbin Liu
2023-07-14 6:51 ` Nikolay Aleksandrov
2023-07-14 2:52 ` [PATCH net 2/2] team: reset team's " Hangbin Liu
2023-07-14 6:48 ` Jiri Pirko
2023-07-14 6:52 ` Nikolay Aleksandrov
2023-07-14 8:10 ` Hangbin Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLEC2OQGS/gFsfKI@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vosburgh@gmail.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=liali@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).