From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Feiyang Chen <chris.chenfeiyang@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Feiyang Chen <chenfeiyang@loongson.cn>,
hkallweit1@gmail.com, peppe.cavallaro@st.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
chenhuacai@loongson.cn, dongbiao@loongson.cn,
loongson-kernel@lists.loongnix.cn, netdev@vger.kernel.org,
loongarch@lists.linux.dev
Subject: Re: [RFC PATCH 00/10] net: phy/stmmac: Add Loongson platform support
Date: Fri, 14 Jul 2023 09:39:07 +0100 [thread overview]
Message-ID: <ZLEJq1G5+7I+FsPo@shell.armlinux.org.uk> (raw)
In-Reply-To: <CACWXhKkUJCFV8DKeAOGPQCfkn8mBhZvBJBMM8SYVgVKY8JEyRw@mail.gmail.com>
On Fri, Jul 14, 2023 at 10:16:07AM +0800, Feiyang Chen wrote:
> On Thu, Jul 13, 2023 at 12:09 PM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Thu, Jul 13, 2023 at 10:46:52AM +0800, Feiyang Chen wrote:
> > > Add driver for Loongson PHY. Extend stmmac functions and macros for
> > > Loongson DWMAC. Add LS7A support for dwmac_loongson.
> >
> > Why is this RFC? What do you actually want comment on?
> >
>
> Hi, Andrew,
>
> I marked this patch series as an RFC because I believe it involves
> significant changes to the dwmac1000 driver. I want comments on the
> design and any alternative suggestions.
That is admirable, but in practice, I've found that posting RFCs is
a waste of effort and time - basically, it seems people ignore
patches posted as RFC.
This turns the whole thing when posting patches into basically what
I'd summarise as "reviewer blackmail" - post the patches non-RFC
even when you want only comments, and reviewers _have_ to comment on
the patches if there's something they don't like to prevent them
being merged.
It's sad that it comes to that, but that is the reality of how things
appear to work.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-07-14 8:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 2:46 [RFC PATCH 00/10] net: phy/stmmac: Add Loongson platform support Feiyang Chen
2023-07-13 2:46 ` [RFC PATCH 01/10] net: phy: Add driver for Loongson PHY Feiyang Chen
2023-07-13 4:00 ` Andrew Lunn
2023-07-14 2:15 ` Feiyang Chen
2023-07-14 4:19 ` Andrew Lunn
2023-07-17 2:43 ` Feiyang Chen
2023-07-17 12:22 ` Andrew Lunn
2023-07-21 3:31 ` Feiyang Chen
2023-07-21 9:04 ` Andrew Lunn
2023-07-25 2:02 ` Feiyang Chen
2023-07-25 17:20 ` Andrew Lunn
2023-07-13 7:53 ` Russell King (Oracle)
2023-07-14 2:41 ` Feiyang Chen
2023-07-13 2:46 ` [RFC PATCH 02/10] net: stmmac: Pass stmmac_priv and chan in some callbacks Feiyang Chen
2023-07-13 4:02 ` Andrew Lunn
2023-07-14 2:16 ` Feiyang Chen
2023-07-13 2:46 ` [RFC PATCH 03/10] net: stmmac: dwmac1000: Allow platforms to choose some register offsets Feiyang Chen
2023-07-13 2:46 ` [RFC PATCH 04/10] net: stmmac: dwmac1000: Add multi-channel support Feiyang Chen
2023-07-13 2:48 ` [RFC PATCH 05/10] net: stmmac: dwmac1000: Add 64-bit DMA support Feiyang Chen
2023-07-13 2:48 ` [RFC PATCH 06/10] net: stmmac: dwmac1000: Add Loongson register definitions Feiyang Chen
2023-07-13 2:48 ` [RFC PATCH 07/10] net: stmmac: Add Loongson HWIF entry Feiyang Chen
2023-07-13 2:48 ` [RFC PATCH 08/10] net: stmmac: dwmac-loongson: Add LS7A support Feiyang Chen
2023-07-13 2:48 ` [RFC PATCH 09/10] net: stmmac: dwmac-loongson: Add 64-bit DMA and multi-vector support Feiyang Chen
2023-07-13 2:49 ` [RFC PATCH 10/10] net: stmmac: dwmac-loongson: Add GNET support Feiyang Chen
2023-07-13 4:07 ` Andrew Lunn
2023-07-14 2:24 ` Feiyang Chen
2023-07-14 4:26 ` Andrew Lunn
2023-07-14 8:52 ` Russell King (Oracle)
2023-07-14 8:45 ` Russell King (Oracle)
2023-07-17 7:54 ` Feiyang Chen
2023-07-13 8:06 ` Russell King (Oracle)
2023-07-14 2:27 ` Feiyang Chen
2023-07-14 4:22 ` Andrew Lunn
2023-07-13 4:09 ` [RFC PATCH 00/10] net: phy/stmmac: Add Loongson platform support Andrew Lunn
2023-07-14 2:16 ` Feiyang Chen
2023-07-14 8:39 ` Russell King (Oracle) [this message]
2023-07-16 14:59 ` Andrew Lunn
2023-07-17 2:57 ` Feiyang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLEJq1G5+7I+FsPo@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@loongson.cn \
--cc=chris.chenfeiyang@gmail.com \
--cc=dongbiao@loongson.cn \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).