From: Guillaume Nault <gnault@redhat.com>
To: Su Hui <suhui@nfschina.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, xeb@mail.ru, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
wuych <yunchuan@nfschina.com>
Subject: Re: [PATCH net-next v2 03/10] net: ppp: Remove unnecessary (void*) conversions
Date: Fri, 14 Jul 2023 11:07:22 +0200 [thread overview]
Message-ID: <ZLEQSivEvfpWXrdr@debian> (raw)
In-Reply-To: <20230710064027.173298-1-suhui@nfschina.com>
On Mon, Jul 10, 2023 at 02:40:27PM +0800, Su Hui wrote:
> From: wuych <yunchuan@nfschina.com>
>
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: wuych <yunchuan@nfschina.com>
> ---
> drivers/net/ppp/pppoe.c | 4 ++--
> drivers/net/ppp/pptp.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Guillaume Nault <gnault@redhat.com>
While there, you might want to also remove the useless casts in
net/l2tp/l2tp_ppp.c and net/atm/pppoatm.c.
> diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
> index 3b79c603b936..ba8b6bd8233c 100644
> --- a/drivers/net/ppp/pppoe.c
> +++ b/drivers/net/ppp/pppoe.c
> @@ -968,7 +968,7 @@ static int __pppoe_xmit(struct sock *sk, struct sk_buff *skb)
> ***********************************************************************/
> static int pppoe_xmit(struct ppp_channel *chan, struct sk_buff *skb)
> {
> - struct sock *sk = (struct sock *)chan->private;
> + struct sock *sk = chan->private;
> return __pppoe_xmit(sk, skb);
> }
>
> @@ -976,7 +976,7 @@ static int pppoe_fill_forward_path(struct net_device_path_ctx *ctx,
> struct net_device_path *path,
> const struct ppp_channel *chan)
> {
> - struct sock *sk = (struct sock *)chan->private;
> + struct sock *sk = chan->private;
> struct pppox_sock *po = pppox_sk(sk);
> struct net_device *dev = po->pppoe_dev;
>
> diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c
> index 32183f24e63f..6b3d3df99549 100644
> --- a/drivers/net/ppp/pptp.c
> +++ b/drivers/net/ppp/pptp.c
> @@ -148,7 +148,7 @@ static struct rtable *pptp_route_output(struct pppox_sock *po,
>
> static int pptp_xmit(struct ppp_channel *chan, struct sk_buff *skb)
> {
> - struct sock *sk = (struct sock *) chan->private;
> + struct sock *sk = chan->private;
> struct pppox_sock *po = pppox_sk(sk);
> struct net *net = sock_net(sk);
> struct pptp_opt *opt = &po->proto.pptp;
> @@ -575,7 +575,7 @@ static int pptp_create(struct net *net, struct socket *sock, int kern)
> static int pptp_ppp_ioctl(struct ppp_channel *chan, unsigned int cmd,
> unsigned long arg)
> {
> - struct sock *sk = (struct sock *) chan->private;
> + struct sock *sk = chan->private;
> struct pppox_sock *po = pppox_sk(sk);
> struct pptp_opt *opt = &po->proto.pptp;
> void __user *argp = (void __user *)arg;
> --
> 2.30.2
>
>
next prev parent reply other threads:[~2023-07-14 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 6:40 [PATCH net-next v2 03/10] net: ppp: Remove unnecessary (void*) conversions Su Hui
2023-07-11 17:50 ` Simon Horman
2023-07-12 1:44 ` yunchuan
2023-07-13 8:41 ` Simon Horman
2023-07-14 9:07 ` Guillaume Nault [this message]
2023-07-17 1:33 ` yunchuan
2023-07-17 13:21 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLEQSivEvfpWXrdr@debian \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=suhui@nfschina.com \
--cc=xeb@mail.ru \
--cc=yunchuan@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).