From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FBCA6FC8 for ; Fri, 14 Jul 2023 10:44:50 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C06E330EF; Fri, 14 Jul 2023 03:44:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3tvyk/IjPd9exDViNcMKn2ye1jKNbDeaF5HrfbZWpg0=; b=dPslXTk5hA0L2gEzfw5+aIotFr eQA5Lv3QCivHPME288NxRw5sI/Px9+J1GOSXhyqPTq0pHJq9tzZ1WOEsEPNpkEe5gLvkvXnufrdCz 7FuwhKzFQIM766FerAPTBOsJnvz3n3uu89wHrirrNLjr1BqMUZIGEEN5Q7p4TStul5eJakRINlESk nWdZwpR3wD+9xpEASu79XS9cMch2wG0lEbSISeDoJ+6JSVNjplaPJkzPIoC/yH8Y76/DmXk6g1Lxf 05DYIkTddY8sdy9cHLt3kDW59ALSXwFiQfzb2dVLNbNTtvSp/B/P1xoj17qlWGEuGjqo8y6FTvK1P 1ZXBt15Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41868) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qKGHy-0000YG-0a; Fri, 14 Jul 2023 11:44:42 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qKGHw-00079f-51; Fri, 14 Jul 2023 11:44:40 +0100 Date: Fri, 14 Jul 2023 11:44:40 +0100 From: "Russell King (Oracle)" To: Luo Jie Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] net: phy: at803x: support qca8081 genphy_c45_pma_read_abilities Message-ID: References: <20230714063136.21368-1-quic_luoj@quicinc.com> <20230714063136.21368-2-quic_luoj@quicinc.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714063136.21368-2-quic_luoj@quicinc.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Fri, Jul 14, 2023 at 02:31:31PM +0800, Luo Jie wrote: > qca8081 PHY supports to use genphy_c45_pma_read_abilities for > getting the PHY features supported except for the autoneg ability > > but autoneg ability exists in MII_BMSR instead of MMD7.1, add it When talking about clause 45 PHYs, they don't have a BMSR. The correct definition is MDIO_STAT1, or "status 1 register". Apart from that, Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!