From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76D9F15B8 for ; Sat, 15 Jul 2023 16:12:20 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E16A710D9 for ; Sat, 15 Jul 2023 09:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689437537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dF7OtGXMRje1f7jke9Bs430OqzMpDW752u+Jth/n5k0=; b=Ff2hFNfBeB9d3mdbB1FwC/CZ/bceqnlLGmuiTOjZIbG37ZvjxYzTI4gsxTo+Ib9F8yilyx w0BUWtsKmbyMO1IFiKp117jc7QySbmubpTy0PT25bE/T2LL5Dzb/dhk8Lv9Y98ybTd/hmB 8z7UnIPBfOn3+OnFsXmHCijmdXuM5fM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-318-jtK9-1LGNPm5qAdYu0stPw-1; Sat, 15 Jul 2023 12:12:15 -0400 X-MC-Unique: jtK9-1LGNPm5qAdYu0stPw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fb40ec952bso15653295e9.0 for ; Sat, 15 Jul 2023 09:12:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689437534; x=1692029534; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dF7OtGXMRje1f7jke9Bs430OqzMpDW752u+Jth/n5k0=; b=FbQDUXcoBXhce3iPWoiNafWZJGOBJb3oDxaBeix82c8w4DeLwvXzt+lfX/1k/0O7ex yDRLNGO4uAnZboQfVCNBsrVZ/AkPnuWNp7+a++JuU1m7Hg6PtqjpccwN+hCG+GrpiLTn 6fCeUpVH79yc22bkh1Mb2DGGBTjPBuvbMFU3S45akGh9NnUmhbrN5we4+xCZIonX2q/s aml9LiC53UORUBkATvG+t3Yp92f8SbcxuXFLJMz6nYKlPNOfSMOrkozeDBwX3aJZfktK tfSHfjgk9FxzgD0oO+H4e2hp1DEqeNHdRrbSZF+bA6Hns2ZbVAlJJrvbmqYAbpofu8WJ 9Bzw== X-Gm-Message-State: ABy/qLZaJHSp0bY7eVVbes/TF6lLnru1oWq/VEVY8AXHJlGtpdg0jLgg 3ENKOGLY6BEMACygbkelG98g0ba5Tb7mNJHdNBhU5NR5vJD4mkI78SIJ6DLCxBNi2fM6pIBh0fy uW2DYJGmRfi2WOzjl X-Received: by 2002:a7b:cd96:0:b0:3fc:10:b25b with SMTP id y22-20020a7bcd96000000b003fc0010b25bmr6623431wmj.21.1689437534442; Sat, 15 Jul 2023 09:12:14 -0700 (PDT) X-Google-Smtp-Source: APBJJlFpxpfSQFWVxs5xId56kuqovmHBkCRVcENJq+und24xVDDj0feG9wpZsKiSMo/jJvMcazXpMg== X-Received: by 2002:a7b:cd96:0:b0:3fc:10:b25b with SMTP id y22-20020a7bcd96000000b003fc0010b25bmr6623408wmj.21.1689437534192; Sat, 15 Jul 2023 09:12:14 -0700 (PDT) Received: from localhost (net-130-25-106-149.cust.vodafonedsl.it. [130.25.106.149]) by smtp.gmail.com with ESMTPSA id y17-20020a1c4b11000000b003fb739d27aesm3922717wma.35.2023.07.15.09.12.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jul 2023 09:12:13 -0700 (PDT) Date: Sat, 15 Jul 2023 18:12:11 +0200 From: Lorenzo Bianconi To: "Russell King (Oracle)" Cc: Daniel Golle , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , =?iso-8859-1?Q?Bj=F8rn?= Mork , Florian Fainelli , Greg Ungerer Subject: Re: [PATCH v2 net-next 3/9] net: ethernet: mtk_eth_soc: add MTK_NETSYS_V1 capability bit Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yB+7pERcjQZkUudn" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net --yB+7pERcjQZkUudn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Thu, Jul 13, 2023 at 03:18:23AM +0100, Daniel Golle wrote: > > From: Lorenzo Bianconi > >=20 > > Introduce MTK_NETSYS_V1 bit in the device capabilities for > > MT7621/MT7622/MT7623/MT7628/MT7629 SoCs. > > Use !MTK_NETSYS_V1 instead of MTK_NETSYS_V2 in the driver codebase. > > This is a preliminary patch to introduce support for MT7988 SoC. >=20 > Rather than using capability bits for versions, would it make more > sense to use an integer for this, so you can do: >=20 > if (eth->soc->netsys_version >=3D 2) { > version 2 and later stuff > } else { > previous version stuff > } >=20 > ? >=20 > I'm just thinking ahead to when we end up with stuff that v1 and v2 > need but v3 and later don't. ack, I will fix it. Regards, Lorenzo >=20 > --=20 > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! >=20 --yB+7pERcjQZkUudn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZLLFWwAKCRA6cBh0uS2t rBvlAQDy03bEQ4loaAkQrbJsOLuS7fpBgSkRYBHq+v1STiH+dwEAhaatBwH6Dv5n 6nKwAO3GR06rfY1eFCm7uJkttIs/XwM= =TLpK -----END PGP SIGNATURE----- --yB+7pERcjQZkUudn--