From: Stefan Eichenberger <eichest@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, hkallweit1@gmail.com,
linux@armlinux.org.uk, francesco.dolcini@toradex.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH net-next v3 5/5] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2110 PHY
Date: Tue, 18 Jul 2023 09:16:32 +0200 [thread overview]
Message-ID: <ZLY7+aM4IUw+T3cH@eichest-laptop> (raw)
In-Reply-To: <dbd85f63-6abc-4824-a5ec-3ed5f270ffeb@lunn.ch>
Hi Andrew,
On Mon, Jul 17, 2023 at 11:54:39PM +0200, Andrew Lunn wrote:
> > +#define MARVELL_PHY_ID_88Q2110 0x002b0981
>
> > +
> > +static struct phy_driver mv88q2xxx_driver[] = {
> > + {
> > + .phy_id = MARVELL_PHY_ID_88Q2110,
> > + .phy_id_mask = MARVELL_PHY_ID_MASK,
>
> Probably not an issue...
>
> The ID you have above is for revision 1 of the PHY. But the mask will
> cause the revision to be ignored. Do you want to ignore the revision?
> Are there different errata for revision 0 and 1?
A0 to A2 (Rev 1-3) are the same software wise for the current scenarios.
Z0 (Rev 0) might behave slightly different in the reset scenario but
most likely it works as well. Unfortunately, I could not test it because
I don't have such a device.
Regards,
Stefan
next prev parent reply other threads:[~2023-07-18 7:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 19:33 [PATCH net-next v3 0/5] Add a driver for the Marvell 88Q2110 PHY Stefan Eichenberger
2023-07-17 19:33 ` [PATCH net-next v3 1/5] net: phy: add registers to support 1000BASE-T1 Stefan Eichenberger
2023-07-17 21:44 ` Andrew Lunn
2023-07-17 19:33 ` [PATCH net-next v3 2/5] net: phy: c45: add support for 1000BASE-T1 forced setup Stefan Eichenberger
2023-07-17 21:44 ` Andrew Lunn
2023-07-17 19:33 ` [PATCH net-next v3 3/5] net: phy: c45: add a separate function to read BASE-T1 abilities Stefan Eichenberger
2023-07-17 21:45 ` Andrew Lunn
2023-07-17 19:33 ` [PATCH net-next v3 4/5] net: phy: c45: detect the BASE-T1 speed from the ability register Stefan Eichenberger
2023-07-17 21:45 ` Andrew Lunn
2023-07-17 19:33 ` [PATCH net-next v3 5/5] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2110 PHY Stefan Eichenberger
2023-07-17 21:54 ` Andrew Lunn
2023-07-18 7:16 ` Stefan Eichenberger [this message]
2023-07-18 13:00 ` Andrew Lunn
2023-07-18 10:48 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLY7+aM4IUw+T3cH@eichest-laptop \
--to=eichest@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=francesco.dolcini@toradex.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).