From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39E2553BF for ; Tue, 18 Jul 2023 07:47:31 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9585DD; Tue, 18 Jul 2023 00:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NboEGMEtSSINFTYAhTdPSs3mcHrjmxWKlp9QfP49pKE=; b=OTHhWJt2wqwUZeixwym/3j9XpL CyIDaE4LQaT1h9FuBQc+SvxAFI0z0708oeRaJAIgI986GFFU1lgHPBjX478+uZ4xiLTB6nZGAM9Y4 wXB2WChuWcdeCJagCjgUwLLJiSs9MdNE7xDWioK97MFn7uh4Zo51fkdIxkqVKNm5WL66Sp6HWTczW zSgqQnmAUrW6MABHdrKXLq7NzRMVveYE/tvUVg8FOdiqgeGCuPJDioZaoQ8zBY1tPVUiFWNFka9Ax DZ15TDsFiuEG33VqAFY8FuitMeQ2vnuoM+Brbtk2DSY/nVvB7wAJsd6ytJ9bAc78BRHMuGaMItzZe WDSZ+3GA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:47624) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qLfQb-0005XY-2e; Tue, 18 Jul 2023 08:47:25 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qLfQZ-0002rl-KX; Tue, 18 Jul 2023 08:47:23 +0100 Date: Tue, 18 Jul 2023 08:47:23 +0100 From: "Russell King (Oracle)" To: "M. Haener" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Sverdlin Subject: Re: [PATCH v3 3/3] net: dsa: mv88e632x: Add SERDES ops Message-ID: References: <20230718065937.10713-1-michael.haener@siemens.com> <20230718065937.10713-4-michael.haener@siemens.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718065937.10713-4-michael.haener@siemens.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, Jul 18, 2023 at 08:59:31AM +0200, M. Haener wrote: > From: Michael Haener > > The 88e632x family has several SERDES 100/1000 blocks. By adding these > operations, these functionalities can be used. > > Signed-off-by: Michael Haener > --- > Changelog: > v3: rebased onto main branch > v2: rebased onto Russell Kings series dsa/88e6xxx/phylink I think you're missing something - you seem to be adding support to read the statistics from these blocks, but you're not actually driving them at all in terms of reading their status or configuring them. You need to modify drivers/net/dsa/mv88e6xxx/pcs-6352.c for that. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!