From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "M. Haener" <michael.haener@siemens.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexander Sverdlin <alexander.sverdlin@siemens.com>
Subject: Re: [PATCH v3 3/3] net: dsa: mv88e632x: Add SERDES ops
Date: Tue, 18 Jul 2023 08:48:29 +0100 [thread overview]
Message-ID: <ZLZDzXQN3MKfOSwk@shell.armlinux.org.uk> (raw)
In-Reply-To: <ZLZDi22lqZfHKFUZ@shell.armlinux.org.uk>
On Tue, Jul 18, 2023 at 08:47:23AM +0100, Russell King (Oracle) wrote:
> On Tue, Jul 18, 2023 at 08:59:31AM +0200, M. Haener wrote:
> > From: Michael Haener <michael.haener@siemens.com>
> >
> > The 88e632x family has several SERDES 100/1000 blocks. By adding these
> > operations, these functionalities can be used.
> >
> > Signed-off-by: Michael Haener <michael.haener@siemens.com>
> > ---
> > Changelog:
> > v3: rebased onto main branch
> > v2: rebased onto Russell Kings series dsa/88e6xxx/phylink
>
> I think you're missing something - you seem to be adding support to read
> the statistics from these blocks, but you're not actually driving them
> at all in terms of reading their status or configuring them.
>
> You need to modify drivers/net/dsa/mv88e6xxx/pcs-6352.c for that.
... and this is why you need to be able to test on recent kernels!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-07-18 7:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 6:59 [PATCH v3 0/3] net: dsa: SERDES support for mv88e632x family M. Haener
2023-07-18 6:59 ` [PATCH v3 1/3] net: dsa: mv88e632x: Refactor serdes read M. Haener
2023-07-18 7:29 ` Sverdlin, Alexander
2023-07-18 6:59 ` [PATCH v3 2/3] net: dsa: mv88e632x: Refactor serdes write M. Haener
2023-07-18 7:30 ` Sverdlin, Alexander
2023-07-18 6:59 ` [PATCH v3 3/3] net: dsa: mv88e632x: Add SERDES ops M. Haener
2023-07-18 7:30 ` Sverdlin, Alexander
2023-07-18 7:47 ` Russell King (Oracle)
2023-07-18 7:48 ` Russell King (Oracle) [this message]
2023-07-18 8:24 ` Sverdlin, Alexander
2023-07-18 8:42 ` Russell King (Oracle)
2023-07-18 8:57 ` Sverdlin, Alexander
2023-07-18 8:24 ` Haener, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLZDzXQN3MKfOSwk@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexander.sverdlin@siemens.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.haener@siemens.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox