From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 672A210EA for ; Tue, 18 Jul 2023 08:42:11 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAE76A6; Tue, 18 Jul 2023 01:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PUFHK/0lkljVDIbxvCvY/jgMbVxQaKpPjRRBnR2abHA=; b=WVdMWGPc/cqXGwQzk2aV/7TJPo 8Eevg/IQq9+aDbDRk2L2XIL4yAWSpa4wWorm1rMZAIN6Z7NpUps8HMLAJNnUJWgqsapRs1FJ+Emq7 Rz9cbbIYhvVFcoFFPMcKYLcr84+svfcE5KpBYcYTIIHhrxqpgNiwNovPj++/Zasa/iBOWZHmwsMZS EGOgbkbBlu1GRWftmyc+djhXIJN0xy1x0n3mrRTDPn58hkWr03iMnoOlZFjnrsm7rGyIF7NvFENoD C9CJEpyX1VB+qg+UAY5iRlyqBiNIaf9SIF3VprsskFMMUJvw4e2mOhSt1BJoKJiynAKtDtsDLF0Ly q056U4Ow==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52264) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qLgHW-0005ay-1G; Tue, 18 Jul 2023 09:42:06 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qLgHV-0002u4-FG; Tue, 18 Jul 2023 09:42:05 +0100 Date: Tue, 18 Jul 2023 09:42:05 +0100 From: "Russell King (Oracle)" To: "Sverdlin, Alexander" Cc: "Haener, Michael" , "andrew@lunn.ch" , "olteanv@gmail.com" , "davem@davemloft.net" , "linux-kernel@vger.kernel.org" , "f.fainelli@gmail.com" , "kuba@kernel.org" , "edumazet@google.com" , "netdev@vger.kernel.org" , "pabeni@redhat.com" Subject: Re: [PATCH v3 3/3] net: dsa: mv88e632x: Add SERDES ops Message-ID: References: <20230718065937.10713-1-michael.haener@siemens.com> <20230718065937.10713-4-michael.haener@siemens.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, Jul 18, 2023 at 08:24:47AM +0000, Sverdlin, Alexander wrote: > Hello Russell, > > On Tue, 2023-07-18 at 08:48 +0100, Russell King (Oracle) wrote: > > On Tue, Jul 18, 2023 at 08:47:23AM +0100, Russell King (Oracle) wrote: > > > On Tue, Jul 18, 2023 at 08:59:31AM +0200, M. Haener wrote: > > > > From: Michael Haener > > > > > > > > The 88e632x family has several SERDES 100/1000 blocks. By adding these > > > > operations, these functionalities can be used. > > > > > > > > Signed-off-by: Michael Haener > > > > --- > > > > Changelog: > > > > v3: rebased onto main branch > > > > v2: rebased onto Russell Kings series dsa/88e6xxx/phylink > > > > > > I think you're missing something - you seem to be adding support to read > > > the statistics from these blocks, but you're not actually driving them > > > at all in terms of reading their status or configuring them. > > > > > > You need to modify drivers/net/dsa/mv88e6xxx/pcs-6352.c for that. > > > > ... and this is why you need to be able to test on recent kernels! > > are you absolutely sure about it? Yes. > mv88e6352_serdes_get_stats() remained in serdes.c after your rework and > as I see it, your rework is about link status, but you didn't touch > registers and statistics. What I said was: "but you're not actually driving them at all in terms of reading their status or configuring them" I was not commenting on obtaining statistics, but the status/control of the blocks, which is now in the PCS drivers. So, right now it looks to me that _all_ this series is doing is providing support to read statistics from the PCS blocks and nothing more, so the cover message for this series is misleading. It is not adding support for the serdes blocks. It is only adding support for reading statistics from the serdes blocks. Either correct the patch series to do what the cover message says it's doing, or change the cover message to properly describe what the series is doing. It needs to be consistent. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!