netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: corbet@lwn.net, workflows@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, gregkh@linuxfoundation.org,
	linux@leemhuis.info, broonie@kernel.org, krzk@kernel.org
Subject: Re: [PATCH docs v2] docs: maintainer: document expectations of small time maintainers
Date: Tue, 18 Jul 2023 15:19:13 -0400	[thread overview]
Message-ID: <ZLblsQe1fLLhZzvU@d3> (raw)
In-Reply-To: <20230718155814.1674087-1-kuba@kernel.org>

On 2023-07-18 08:58 -0700, Jakub Kicinski wrote:
[...]
> +Reviews
> +-------
> +
> +Maintainers must review *all* patches touching exclusively their drivers,
> +no matter how trivial. If the patch is a tree wide change and modifies
> +multiple drivers - whether to provide a review is left to the maintainer.
> +
> +There should be multiple maintainers for any piece of code, an ``Acked-by``
> +or ``Reviewed-by`` tag (or review comments) from a single maintainer is
> +enough to satisfy this requirement.

This sentence seems strange. Were the first two words swapped?

Given the latter part of the document which recommends to have multiple
maintainers, maybe this sentence could begin with "When there are
multiple maintainers for a piece of code". That sounds less speculative.

[...]
> +Non compliance
> +==============
> +
> +Subsystem maintainers may remove inactive maintainers from the MAINTAINERS
> +file. If the maintainer was a significant author or have played an important
> +role in the development of the code they should be moved to the CREDITS file.

         If the maintainer was a significant author or played an important
   role in the development of the code, they should be moved to the CREDITS file.

  parent reply	other threads:[~2023-07-18 19:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-18 15:58 [PATCH docs v2] docs: maintainer: document expectations of small time maintainers Jakub Kicinski
2023-07-18 16:55 ` Andrew Lunn
2023-07-18 17:34 ` Greg KH
2023-07-18 18:06 ` Krzysztof Kozlowski
2023-07-18 19:19 ` Benjamin Poirier [this message]
2023-07-18 19:55 ` Mark Brown
2023-07-19 18:26   ` Jakub Kicinski
2023-07-18 22:02 ` Shannon Nelson
2023-07-19  7:27 ` Leon Romanovsky
2023-07-19 17:54 ` Rob Herring
2023-07-19 18:36   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLblsQe1fLLhZzvU@d3 \
    --to=benjamin.poirier@gmail.com \
    --cc=broonie@kernel.org \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=netdev@vger.kernel.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).