From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1B3510961 for ; Wed, 19 Jul 2023 09:14:08 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3854C19B4 for ; Wed, 19 Jul 2023 02:14:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bej1uizILHHV76GP1k1h8jN6rm9Rqan2jN5WfXSgkNE=; b=1JmMzvwaMLcoQjfQHveoks605r rVl4GWi8Og9GeDcdUaWSUnuk2lkac4nyqbuoOXbYmOmRfGRcn3PpLf9EyOiClpKz7Al2wruuxGwB+ hq3VIVkcb9ctJgT8vBeS3iKNfEJ6/SP0kp78rwT7zNKQy8GoAG0CySlH6ni5euKTLTyjoN3mi1upU 8LSbl3PfaD2+/VHyIAxnRqDJ3BGDbZGf6QnZxrMWH8C36iivrGs6jHYx64xTOJ6q9M7tVTBrz+KlB NpdOLC6Ve59Wbp8aIBnDanlNRuiVqb2EKjnMchw5g8VluuOGnZergO28GPlrwCDUtqTbHk+weIWv8 iyeHJQdg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41906) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qM3Fs-0007Fl-2V; Wed, 19 Jul 2023 10:13:56 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qM3Fs-0003xN-63; Wed, 19 Jul 2023 10:13:56 +0100 Date: Wed, 19 Jul 2023 10:13:56 +0100 From: "Russell King (Oracle)" To: Jiawen Wu Cc: kabel@kernel.org, andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: Re: [PATCH net v2] net: phy: marvell10g: fix 88x3310 power up Message-ID: References: <20230719092233.137844-1-jiawenwu@trustnetic.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230719092233.137844-1-jiawenwu@trustnetic.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Jul 19, 2023 at 05:22:33PM +0800, Jiawen Wu wrote: > Clear MV_V2_PORT_CTRL_PWRDOWN bit to set power up for 88x3310 PHY, > it sometimes does not take effect immediately. And a read of this > register causes the bit not to clear. This will cause mv3310_reset() > to time out, which will fail the config initialization. So add a delay > before the next access. > > Fixes: c9cc1c815d36 ("net: phy: marvell10g: place in powersave mode at probe") > Signed-off-by: Jiawen Wu Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!