From: Simon Horman <simon.horman@corigine.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Lukasz Plachno <lukasz.plachno@intel.com>,
Benjamin Mikailenko <benjamin.mikailenko@intel.com>
Subject: Re: [PATCH iwl-net] ice: Reset stats on queues num change
Date: Wed, 19 Jul 2023 15:04:20 +0100 [thread overview]
Message-ID: <ZLftZFND6uBiHMC4@corigine.com> (raw)
In-Reply-To: <20230714114721.335526-1-przemyslaw.kitszel@intel.com>
On Fri, Jul 14, 2023 at 07:47:21AM -0400, Przemek Kitszel wrote:
> Reset VSI stats on queues number change.
>
> Commit 288ecf491b16 ("ice: Accumulate ring statistics over reset")
> implemented functionality for interface statistics to persist over reset,
> but it left stats persisting over queue count reconfiguration.
>
> Following scenario is fixed here:
> # Observe statistics for Tx/Rx queues
> ethtool -S ethX
> # change number of queues
> ethtool -L ethX combined 10
> # Observe statistics for Tx/Rx queues (after reset)
> ethtool -S ethX
>
> Ben has left a note where to place the VSI stats reset,
> what made this fix much easier to do.
>
> Note that newly allocated structs (case of num_txq > prev_txq) don't
> need zeroing.
>
> Fixes: 288ecf491b16 ("ice: Accumulate ring statistics over reset")
> Suggested-by: Benjamin Mikailenko <benjamin.mikailenko@intel.com>
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-07-19 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 11:47 [PATCH iwl-net] ice: Reset stats on queues num change Przemek Kitszel
2023-07-19 14:04 ` Simon Horman [this message]
2023-07-19 15:25 ` [Intel-wired-lan] " Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLftZFND6uBiHMC4@corigine.com \
--to=simon.horman@corigine.com \
--cc=anthony.l.nguyen@intel.com \
--cc=benjamin.mikailenko@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=lukasz.plachno@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).