From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Andrew Lunn" <andrew@lunn.ch>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
DanielGolle <daniel@makrotopia.org>,
"Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Frank Wunderlich" <frank-w@public-files.de>,
"David Woodhouse" <dwmw@amazon.co.uk>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>, Felix Fietkau <nbd@nbd.name>,
Jakub Kicinski <kuba@kernel.org>, John Crispin <john@phrozen.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Lorenzo Bianconi <lorenzo@kernel.org>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Sean Wang <sean.wang@mediatek.com>
Subject: [PATCH net-next 0/4] Remove legacy phylink behaviour
Date: Fri, 21 Jul 2023 12:33:52 +0100 [thread overview]
Message-ID: <ZLptIKEb7qLY5LmS@shell.armlinux.org.uk> (raw)
Hi,
This series removes the - as far as I can tell - unreachable code in
mtk_eth_soc that relies upon legacy phylink behaviour, and then removes
the support in phylink for this legacy behaviour.
Patch 1 removes the clocking configuration from mtk_eth_soc for non-
TRGMII, non-serdes based interface modes, and disables those interface
modes prior to phylink configuration.
Patch 2 removes the mac_pcs_get_state() method from mtk_eth_soc which
I believe is also not used - mtk_eth_soc appears not to be used with
SFPs (which would use a kind of in-band mode) nor does any DT appear
to specify in-band mode for any non-serdes based interface mode.
With both of those dealt with, the kernel is now free of any driver
relying on the phylink legacy mode. Therefore, patch 3 removes support
for this.
Finally, with the advent of a new driver being submitted today that
makes use of state->speed in the mac_config() path, patch 4 ensures that
any phylink_link_state member that should not be used in mac_config is
either cleared or set to an invalid value.
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 94 +++++------------------------
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 1 +
drivers/net/phy/phylink.c | 48 ++++++---------
include/linux/phylink.h | 45 ++------------
4 files changed, 42 insertions(+), 146 deletions(-)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next reply other threads:[~2023-07-21 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 11:33 Russell King (Oracle) [this message]
2023-07-21 11:34 ` [PATCH net-next 1/4] net: ethernet: mtk_eth_soc: remove incorrect PLL configuration Russell King (Oracle)
2023-07-21 11:34 ` [PATCH net-next 2/4] net: ethernet: mtk_eth_soc: remove mac_pcs_get_state and modernise Russell King (Oracle)
2023-07-21 11:34 ` [PATCH net-next 3/4] net: phylink: strip out pre-March 2020 legacy code Russell King (Oracle)
2023-07-21 11:34 ` [PATCH net-next 4/4] net: phylink: explicitly invalidate link_state members in mac_config Russell King (Oracle)
2023-07-21 16:38 ` [PATCH net-next 0/4] Remove legacy phylink behaviour Russell King (Oracle)
2023-07-21 22:40 ` Daniel Golle
2023-07-22 12:31 ` Aw: " Frank Wunderlich
2023-07-22 12:43 ` Daniel Golle
2023-07-22 16:14 ` Russell King (Oracle)
2023-07-22 18:00 ` Aw: " Frank Wunderlich
2023-07-22 19:40 ` Russell King (Oracle)
2023-07-22 20:32 ` [PATCH net-next 1/4] net: ethernet: mtk_eth_soc: remove incorrect PLL configuration Russell King (Oracle)
2023-07-22 20:32 ` [PATCH net-next 2/4] net: ethernet: mtk_eth_soc: remove mac_pcs_get_state and modernise Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLptIKEb7qLY5LmS@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Mark-MC.Lee@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=edumazet@google.com \
--cc=frank-w@public-files.de \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).