From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56B6127F0A for ; Fri, 21 Jul 2023 16:39:30 +0000 (UTC) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F4713C39 for ; Fri, 21 Jul 2023 09:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HYqUPAIrSyIKACoBmdRKGbmnsQL3FDwv+JyaUfS+PO4=; b=VXRjkr/YMXtrNWUpXn2rMP3W7C OVoKIkRL7BktJwrlCexnilWy237xXIbDGjAXqongcW1zu5vEpD4CbRP5ZI1B18B6fG8ElibIGnmhy HMGxD2PSuhEP7u9QxprgeaRsm9740+NONo/9m7/hjyigyzSOETj2MqnA9HoSZ5YnSlycxSWRQtg/j V1l4HLfKSpG6BWye3StGuB+idR9C6te5WmMoqEGFUyNbvTvH5+sP7udnZmbEA3utvrT8hvv2CY9Vy gAmmOPxQVfkhG8i/XbOVzy8FiUPaAZPYHP6hVbt66InT9Rs6xJ3LY361oAe/ELAf+pMFLBHU7ZbPD PTgQ6Azw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:53220) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qMt8u-0004LR-1O; Fri, 21 Jul 2023 17:38:12 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qMt8o-0006HJ-M8; Fri, 21 Jul 2023 17:38:06 +0100 Date: Fri, 21 Jul 2023 17:38:06 +0100 From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit , DanielGolle , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Frank Wunderlich , David Woodhouse Cc: AngeloGioacchino Del Regno , "David S. Miller" , Eric Dumazet , Felix Fietkau , Jakub Kicinski , John Crispin , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Lorenzo Bianconi , Mark Lee , Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , Sean Wang Subject: Re: [PATCH net-next 0/4] Remove legacy phylink behaviour Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Fri, Jul 21, 2023 at 12:33:52PM +0100, Russell King (Oracle) wrote: > Hi, > > This series removes the - as far as I can tell - unreachable code in > mtk_eth_soc that relies upon legacy phylink behaviour, and then removes > the support in phylink for this legacy behaviour. > > Patch 1 removes the clocking configuration from mtk_eth_soc for non- > TRGMII, non-serdes based interface modes, and disables those interface > modes prior to phylink configuration. > > Patch 2 removes the mac_pcs_get_state() method from mtk_eth_soc which > I believe is also not used - mtk_eth_soc appears not to be used with > SFPs (which would use a kind of in-band mode) nor does any DT appear > to specify in-band mode for any non-serdes based interface mode. > > With both of those dealt with, the kernel is now free of any driver > relying on the phylink legacy mode. Therefore, patch 3 removes support > for this. > > Finally, with the advent of a new driver being submitted today that > makes use of state->speed in the mac_config() path, patch 4 ensures that > any phylink_link_state member that should not be used in mac_config is > either cleared or set to an invalid value. Note: probably be a good idea for the mtk_eth_soc people to review and ack before applying this to net-next. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!