From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EC0F4431 for ; Sat, 22 Jul 2023 12:43:51 +0000 (UTC) Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6176110FD for ; Sat, 22 Jul 2023 05:43:48 -0700 (PDT) Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1qNBx5-0007uX-3D; Sat, 22 Jul 2023 12:43:16 +0000 Date: Sat, 22 Jul 2023 13:43:07 +0100 From: Daniel Golle To: Frank Wunderlich Cc: "Russell King (Oracle)" , Andrew Lunn , Heiner Kallweit , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , David Woodhouse , AngeloGioacchino Del Regno , "David S. Miller" , Eric Dumazet , Felix Fietkau , Jakub Kicinski , John Crispin , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Lorenzo Bianconi , Mark Lee , Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , Sean Wang Subject: Re: Aw: Re: [PATCH net-next 0/4] Remove legacy phylink behaviour Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Sat, Jul 22, 2023 at 02:31:45PM +0200, Frank Wunderlich wrote: > Hi > > > Gesendet: Samstag, 22. Juli 2023 um 00:40 Uhr > > Von: "Daniel Golle" > > > > Hi Russell, > > > > On Fri, Jul 21, 2023 at 12:33:52PM +0100, Russell King (Oracle) wrote: > > > Hi, > > > > > > This series removes the - as far as I can tell - unreachable code in > > > mtk_eth_soc that relies upon legacy phylink behaviour, and then removes > > > the support in phylink for this legacy behaviour. > > > > > > Patch 1 removes the clocking configuration from mtk_eth_soc for non- > > > TRGMII, non-serdes based interface modes, and disables those interface > > > modes prior to phylink configuration. > > > > > > Patch 2 removes the mac_pcs_get_state() method from mtk_eth_soc which > > > I believe is also not used - mtk_eth_soc appears not to be used with > > > SFPs (which would use a kind of in-band mode) nor does any DT appear > > > to specify in-band mode for any non-serdes based interface mode. > > > > > > With both of those dealt with, the kernel is now free of any driver > > > relying on the phylink legacy mode. Therefore, patch 3 removes support > > > for this. > > > > > > Finally, with the advent of a new driver being submitted today that > > > makes use of state->speed in the mac_config() path, patch 4 ensures that > > > any phylink_link_state member that should not be used in mac_config is > > > either cleared or set to an invalid value. > > > > Thank you for taking care of this! > > > For the whole series: > > > > Reviewed-by: Daniel Golle > > Tested-by: Daniel Golle > > > > Tested on BPi-R2 (MT7623N), BPi-R3 (MT7986A) and BPi-R64 (MT7622A). > > All works fine as expected. > > have you changed anything? > > in my test with bpi-r2 i see boot hangs after link-up on my wan-port (still trgmii-mode configured), no access to userspace. > > [ 10.881844] mtk_soc_eth 1b100000.ethernet eth0: configuring for fixed/trgmii link mode > [ 10.891611] mtk_soc_eth 1b100000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx > [ 11.005814] mt7530-mdio mdio-bus:1f wan: configuring for phy/gmii link mode > [ 11.016654] mt7530-mdio mdio-bus:1f lan3: configuring for phy/gmii link mode > [ 11.025685] mt7530-mdio mdio-bus:1f lan2: configuring for phy/gmii link mode > [ 11.035122] mt7530-mdio mdio-bus:1f lan1: configuring for phy/gmii link mode > [ 11.045370] mt7530-mdio mdio-bus:1f lan0: configuring for phy/gmii link mode > > [ 15.144255] mt7530-mdio mdio-bus:1f wan: Link is Up - 1Gbps/Full - flow control rx/tx > > removing the cable does not show link down so it looks like completely stalled...but also no panic/crash or similar. > When booting without cable it hangs too (without the up-message of course). > > > To apply the series I needed to resolve a minor conflict due to > > net: ethernet: mtk_ppe: add MTK_FOE_ENTRY_V{1,2}_SIZE macros > > being applied in the meantime. > > i used yesterdays net-next (6.5-rc2) and put series on top (also needed to do one hunk of first patch manually) and > then my defconfig,buildscript etc. maybe i miss anything? I tested in a fairly similar way. > > afair trgmii is basicly rgmii only with higher clock-setting...and if this is dropped from mac-driver but switch is still using it it cannot work, but i'm sure you know this ;) For TRGMII mode mtk_gmac0_rgmii_adjust behavior should not have changed, only speed-dependent adjustments for RGMII have been dropped. I also didn't not see such a problem when I was testing. However, I guess in my case the MAC interface mode has already been setup in hardware because I booted the board via TFTP, hence U-Boot already took care of initializing everything, so that can also be a reason why it worked fine for me.