From: Ido Schimmel <idosch@idosch.org>
To: Trevor Gamblin <tgamblin@baylibre.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] bridge/mdb.c: include limits.h
Date: Sun, 23 Jul 2023 10:31:05 +0300 [thread overview]
Message-ID: <ZLzXOR6pS/2P+BUX@shredder> (raw)
In-Reply-To: <20230720203726.2316251-1-tgamblin@baylibre.com>
On Thu, Jul 20, 2023 at 04:37:26PM -0400, Trevor Gamblin wrote:
> While building iproute2 6.4.0 with musl using Yocto Project, errors such
> as the following were encountered:
>
> | mdb.c: In function 'mdb_parse_vni':
> | mdb.c:666:47: error: 'ULONG_MAX' undeclared (first use in this function)
> | 666 | if ((endptr && *endptr) || vni_num == ULONG_MAX)
> | | ^~~~~~~~~
> | mdb.c:666:47: note: 'ULONG_MAX' is defined in header '<limits.h>'; did you forget to '#include <limits.h>'?
>
> Include limits.h in bridge/mdb.c to fix this issue. This change is based
> on one in Alpine Linux, but the author there had no plans to submit:
> https://git.alpinelinux.org/aports/commit/main/iproute2/include.patch?id=bd46efb8a8da54948639cebcfa5b37bd608f1069
>
> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Fixes: c5b327e5707b ("bridge: mdb: Add destination VNI support")
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Similar change was done in commit dd9cc0ee81a6 ("iproute2: various
header include fixes for compiling with musl libc").
Thanks
next prev parent reply other threads:[~2023-07-23 7:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 20:37 [PATCH iproute2] bridge/mdb.c: include limits.h Trevor Gamblin
2023-07-23 7:31 ` Ido Schimmel [this message]
2023-07-25 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLzXOR6pS/2P+BUX@shredder \
--to=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
--cc=tgamblin@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox