From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
Frank Li <frank.li@nxp.com>
Subject: Re: [PATCH] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link
Date: Tue, 25 Jul 2023 22:04:37 +0100 [thread overview]
Message-ID: <ZMA45XUMM94GTjHx@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230725194931.1989102-1-shenwei.wang@nxp.com>
On Tue, Jul 25, 2023 at 02:49:31PM -0500, Shenwei Wang wrote:
> +static bool imx_dwmac_is_fixed_link(struct imx_priv_data *dwmac)
> +{
> + struct plat_stmmacenet_data *plat_dat;
> + struct device_node *dn;
> +
> + if (!dwmac || !dwmac->plat_dat)
> + return false;
> +
> + plat_dat = dwmac->plat_dat;
> + dn = of_get_child_by_name(dwmac->dev->of_node, "fixed-link");
> + if (!dn)
> + return false;
> +
> + if (plat_dat->phy_node == dn || plat_dat->phylink_node == dn)
> + return true;
Why would the phy_node or the phylink_node ever be pointing at the
fixed-link node?
For one, phylink expects the fwnode being passed to it to be pointing
at the _parent_ node of the fixed-link node, since it looks up from
the parent for "fixed-link" node.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-07-25 21:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 19:49 [PATCH] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link Shenwei Wang
2023-07-25 21:04 ` Russell King (Oracle) [this message]
2023-07-26 15:00 ` [EXT] " Shenwei Wang
2023-07-26 15:09 ` Russell King (Oracle)
2023-07-26 16:10 ` Shenwei Wang
2023-07-26 16:29 ` Russell King (Oracle)
2023-07-26 17:03 ` Vladimir Oltean
2023-07-26 18:24 ` Shenwei Wang
2023-07-26 18:30 ` Andrew Lunn
2023-07-25 23:23 ` kernel test robot
2023-07-26 0:43 ` Vladimir Oltean
2023-07-26 15:10 ` [EXT] " Shenwei Wang
2023-07-26 15:29 ` Russell King (Oracle)
2023-07-26 15:59 ` Shenwei Wang
2023-07-26 17:01 ` Russell King (Oracle)
2023-07-26 18:47 ` Shenwei Wang
2023-07-26 19:02 ` Russell King (Oracle)
2023-07-26 19:17 ` Shenwei Wang
2023-07-27 8:58 ` Russell King (Oracle)
2023-07-27 13:03 ` Shenwei Wang
2023-07-26 8:32 ` Andrew Lunn
2023-07-26 11:58 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMA45XUMM94GTjHx@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shenwei.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).