From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3AD21AA6C for ; Wed, 26 Jul 2023 17:09:12 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C02CD1BE3 for ; Wed, 26 Jul 2023 10:09:10 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 394185C00F9; Wed, 26 Jul 2023 13:09:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 26 Jul 2023 13:09:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1690391350; x=1690477750; bh=ggN26GMAWWRV1 00Nbdaqj7DCJiOU/qF3Y/Smhz6qlec=; b=FOyQd95I+4dCGnwHSe7mrvX4yGA/T cTpT8cLE1IP94DSZvvc0+kltl4Tc7UorkVDSEJtHV6CXcDnBisu0IKtF9koX1n7P Fz2U3ER63Xyosi+kYi37o1t0bSR+kPvjjPQH6YnhJvjn0SCEgCcYL4lLjyUcVBC4 NwL6TgP0N7SgvoGCv1BCMYY1L9k9Oir2TlTC+BcUW50+nsySwwaTPZBlhb//l6BK QbX4GyuEtISYk6qYALA9Q1TqCH+KLFvEVTMLqitYcfGRsQQZlOo+cgk/Pi0GAwcw PTsGf6DKx8xNbJf63Ta1jUnDgSh5c86M0UiBzNhosFL/9w0M/QtFh3esg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedriedvgddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepvddufeevkeehueegfedtvdevfefgudeifeduieefgfelkeehgeelgeejjeeg gefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 26 Jul 2023 13:09:08 -0400 (EDT) Date: Wed, 26 Jul 2023 20:09:05 +0300 From: Ido Schimmel To: Eric Dumazet Cc: "David S . Miller" , Jakub Kicinski , Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko , netdev@vger.kernel.org, eric.dumazet@gmail.com, syzbot , Zahari Doychev , Simon Horman , Ido Schimmel Subject: Re: [PATCH v2 net] net: flower: fix stack-out-of-bounds in fl_set_key_cfm() Message-ID: References: <20230726145815.943910-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726145815.943910-1-edumazet@google.com> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Jul 26, 2023 at 02:58:15PM +0000, Eric Dumazet wrote: > Typical misuse of > > nla_parse_nested(array, XXX_MAX, ...); > > array must be declared as > > struct nlattr *array[XXX_MAX + 1]; > > v2: Based on feedbacks from Ido Schimmel and Zahari Doychev, > I also changed TCA_FLOWER_KEY_CFM_OPT_MAX and cfm_opt_policy > definitions. > [...] > > Fixes: 7cfffd5fed3e ("net: flower: add support for matching cfm fields") > Reported-by: syzbot > Signed-off-by: Eric Dumazet > Cc: Zahari Doychev > Cc: Simon Horman > Cc: Ido Schimmel Reviewed-by: Ido Schimmel Thanks