From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A8451AA60 for ; Wed, 26 Jul 2023 17:58:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDD302688; Wed, 26 Jul 2023 10:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YPmagiFQ/MeFHRjwmSRL0hWWXD4WhK730BMoQ57Tcfs=; b=kixqBCkSocxZEhHc2Sl4YQ3j/W 6MHhYsaeGcAEFz3Ikfkl0tpJZeVVuCe/BiTxlYG3dJ8HcvJ/T2vdQAQ5gIBhR2n6UhgaBfMrG4PI3 Z5Id/jv1a75gsjOtDXpt/LD7O15Touqa7NqiEPt/l8zBxXGlzsYO+bCoXjnUd4LyKsNR8uZGhhZRg +OyiKfgZbY7fbFXMfGEJdwxH3fx8IGSflQLhVMJDAioTezH4kPOYHszoYxlRVTrC6/MqPhn7X667m QRhIOcxcm6QRQ5XuiNwXgc2BldKLdF/obVnyC8UpbIg6DWBIlRNSJNh4WSktu5vL21AXLcVy8pPM7 x0bCwxMw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qOimM-00BE8R-2H; Wed, 26 Jul 2023 17:58:30 +0000 Date: Wed, 26 Jul 2023 10:58:30 -0700 From: Luis Chamberlain To: Joel Granados , Greg Kroah-Hartman Cc: Catalin Marinas , Will Deacon , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Kees Cook , Iurii Zaikin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , willy@infradead.org, josh@joshtriplett.org, Christian Borntraeger , Sven Schnelle , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 06/14] sysctl: Add size to register_sysctl Message-ID: References: <20230726140635.2059334-1-j.granados@samsung.com> <20230726140635.2059334-7-j.granados@samsung.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726140635.2059334-7-j.granados@samsung.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Jul 26, 2023 at 04:06:26PM +0200, Joel Granados wrote: > In order to remove the end element from the ctl_table struct arrays, we > replace the register_syctl function with a macro that will add the > ARRAY_SIZE to the new register_sysctl_sz function. In this way the > callers that are already using an array of ctl_table structs do not have > to change. We *do* change the callers that pass the ctl_table array as a > pointer. Thanks for doing this and this series! > Signed-off-by: Joel Granados > --- > diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h > index 0495c858989f..b1168ae281c9 100644 > --- a/include/linux/sysctl.h > +++ b/include/linux/sysctl.h > @@ -215,6 +215,9 @@ struct ctl_path { > const char *procname; > }; > > +#define register_sysctl(path, table) \ > + register_sysctl_sz(path, table, ARRAY_SIZE(table)) > + > #ifdef CONFIG_SYSCTL Wasn't it Greg who had suggested this? Maybe add Suggested-by with him on it. Also, your cover letter and first few patches are not CC'd to the netdev list or others. What you want to do is collect all the email addresses for this small patch series and add them to who you email for your entire series, otherwise at times they won't be able to properly review or understand the exact context of the changes. You want folks to do less work to review, not more. So please resend and add others to the other patches. Luis