netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: j.vosburgh@gmail.com, andy@greyhouse.net, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	jon.toppins+linux@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next] bonding: 3ad: Remove unused declaration bond_3ad_update_lacp_active()
Date: Thu, 27 Jul 2023 11:22:41 +0800	[thread overview]
Message-ID: <ZMHjAWT60adJfhqY@Laptop-X1> (raw)
In-Reply-To: <20230726143816.15280-1-yuehaibing@huawei.com>

On Wed, Jul 26, 2023 at 10:38:16PM +0800, YueHaibing wrote:
> This is not used since commit 3a755cd8b7c6 ("bonding: add new option lacp_active")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

It looks like a function I added in the draft patch and forgot to remove it
when post... Thanks for the fix.

Acked-by: Hangbin Liu <liuhangbin@gmail.com>

> ---
> v2: fix patch prefix
> ---
>  include/net/bond_3ad.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/net/bond_3ad.h b/include/net/bond_3ad.h
> index a016f275cb01..c5e57c6bd873 100644
> --- a/include/net/bond_3ad.h
> +++ b/include/net/bond_3ad.h
> @@ -301,7 +301,6 @@ int  __bond_3ad_get_active_agg_info(struct bonding *bond,
>  int bond_3ad_lacpdu_recv(const struct sk_buff *skb, struct bonding *bond,
>  			 struct slave *slave);
>  int bond_3ad_set_carrier(struct bonding *bond);
> -void bond_3ad_update_lacp_active(struct bonding *bond);
>  void bond_3ad_update_lacp_rate(struct bonding *bond);
>  void bond_3ad_update_ad_actor_settings(struct bonding *bond);
>  int bond_3ad_stats_fill(struct sk_buff *skb, struct bond_3ad_stats *stats);
> -- 
> 2.34.1
> 

  reply	other threads:[~2023-07-27  3:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 14:38 [PATCH v2 net-next] bonding: 3ad: Remove unused declaration bond_3ad_update_lacp_active() YueHaibing
2023-07-27  3:22 ` Hangbin Liu [this message]
2023-07-29  1:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMHjAWT60adJfhqY@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=j.vosburgh@gmail.com \
    --cc=jon.toppins+linux@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).