From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAC8FDDD9 for ; Thu, 27 Jul 2023 08:59:10 +0000 (UTC) Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAA21272E for ; Thu, 27 Jul 2023 01:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=F+54Rr5uw29T2tRPmyJTl5sfmrbuhWUP5cKAQggrocA=; b=DjL9WdDG/0kgbuSaoTwV3yFdg9 lSYhKbHVF4mzAxHnzGtW7K0PpANxjHbPQX8xSwFMD7iiigOS2/Sn9d82Rd4J/KxSIXjJFycKTPqiS rfv2p4ErUBAEjfWH6ywhrR4miNIngrpxJ9NRGTKkS94qkUvbjVYj8U6uQb17tbu81UfsK28y7CBBs VowBZP/L3wJFUGqzBSbQJ21yG5sXlNFU1uxvB3yEm0/v5bGJg78kNXY8ZPcpgddllL7/1tRsgT+KY vAYbkpe41pBa2KZLp11+eLB9UgkBgdJfnp7gSEArhxTuNN5U/hZV/4P1Aa862Fpzxoi6Q6JdriOOD HjfnW+sA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46140) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qOwpe-0005Z8-2m; Thu, 27 Jul 2023 09:58:50 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qOwpb-0003la-Il; Thu, 27 Jul 2023 09:58:47 +0100 Date: Thu, 27 Jul 2023 09:58:47 +0100 From: "Russell King (Oracle)" To: Shenwei Wang Cc: Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Shawn Guo , dl-linux-imx , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "imx@lists.linux.dev" , Frank Li Subject: Re: [EXT] Re: [PATCH] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link Message-ID: References: <20230725194931.1989102-1-shenwei.wang@nxp.com> <20230726004338.6i354ue576hb35of@skbuf> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Jul 26, 2023 at 07:17:59PM +0000, Shenwei Wang wrote: > > Because of_phy_is_fixed_link() has to chase various pointers, walk the child > > nodes and do a string compare on each, whereas you could just be testing an > > integer! > > > > I don't think It's worth the effort to change the definition of fix_mac_speed across all platforms, > because the function is only called once when the interface is up. If you look at Feiyang Chen's patch set, then his first patch of his set adds a pointer to struct stmmac_priv to a whole bunch of callbacks used between the stmmac core and the various implementations. If you're not willing to do it, then I will send a patch instead. I don't see what the problem is. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!