netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] bridge: Remove unused declaration br_multicast_set_hash_max()
@ 2023-07-26 14:31 YueHaibing
  2023-07-27 11:29 ` Simon Horman
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: YueHaibing @ 2023-07-26 14:31 UTC (permalink / raw)
  To: roopa, razor, davem, edumazet, kuba, pabeni, idosch
  Cc: bridge, netdev, linux-kernel, YueHaibing

Since commit 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable")
this is not used, so can remove it.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 net/bridge/br_private.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 51e4ca54b537..a1f4acfa6994 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -974,7 +974,6 @@ int br_multicast_set_vlan_router(struct net_bridge_vlan *v, u8 mcast_router);
 int br_multicast_toggle(struct net_bridge *br, unsigned long val,
 			struct netlink_ext_ack *extack);
 int br_multicast_set_querier(struct net_bridge_mcast *brmctx, unsigned long val);
-int br_multicast_set_hash_max(struct net_bridge *br, unsigned long val);
 int br_multicast_set_igmp_version(struct net_bridge_mcast *brmctx,
 				  unsigned long val);
 #if IS_ENABLED(CONFIG_IPV6)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] bridge: Remove unused declaration br_multicast_set_hash_max()
  2023-07-26 14:31 [PATCH net-next] bridge: Remove unused declaration br_multicast_set_hash_max() YueHaibing
@ 2023-07-27 11:29 ` Simon Horman
  2023-07-27 11:44 ` Nikolay Aleksandrov
  2023-07-28  0:20 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2023-07-27 11:29 UTC (permalink / raw)
  To: YueHaibing
  Cc: roopa, razor, davem, edumazet, kuba, pabeni, idosch, bridge,
	netdev, linux-kernel

On Wed, Jul 26, 2023 at 10:31:41PM +0800, YueHaibing wrote:
> Since commit 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable")
> this is not used, so can remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] bridge: Remove unused declaration br_multicast_set_hash_max()
  2023-07-26 14:31 [PATCH net-next] bridge: Remove unused declaration br_multicast_set_hash_max() YueHaibing
  2023-07-27 11:29 ` Simon Horman
@ 2023-07-27 11:44 ` Nikolay Aleksandrov
  2023-07-28  0:20 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Nikolay Aleksandrov @ 2023-07-27 11:44 UTC (permalink / raw)
  To: YueHaibing, roopa, davem, edumazet, kuba, pabeni, idosch
  Cc: bridge, netdev, linux-kernel

On 7/26/23 17:31, YueHaibing wrote:
> Since commit 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable")
> this is not used, so can remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   net/bridge/br_private.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 51e4ca54b537..a1f4acfa6994 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -974,7 +974,6 @@ int br_multicast_set_vlan_router(struct net_bridge_vlan *v, u8 mcast_router);
>   int br_multicast_toggle(struct net_bridge *br, unsigned long val,
>   			struct netlink_ext_ack *extack);
>   int br_multicast_set_querier(struct net_bridge_mcast *brmctx, unsigned long val);
> -int br_multicast_set_hash_max(struct net_bridge *br, unsigned long val);
>   int br_multicast_set_igmp_version(struct net_bridge_mcast *brmctx,
>   				  unsigned long val);
>   #if IS_ENABLED(CONFIG_IPV6)

Acked-by: Nikolay Aleksandrov <razor@blackwall.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] bridge: Remove unused declaration br_multicast_set_hash_max()
  2023-07-26 14:31 [PATCH net-next] bridge: Remove unused declaration br_multicast_set_hash_max() YueHaibing
  2023-07-27 11:29 ` Simon Horman
  2023-07-27 11:44 ` Nikolay Aleksandrov
@ 2023-07-28  0:20 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-28  0:20 UTC (permalink / raw)
  To: Yue Haibing
  Cc: roopa, razor, davem, edumazet, kuba, pabeni, idosch, bridge,
	netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 26 Jul 2023 22:31:41 +0800 you wrote:
> Since commit 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable")
> this is not used, so can remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  net/bridge/br_private.h | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - [net-next] bridge: Remove unused declaration br_multicast_set_hash_max()
    https://git.kernel.org/netdev/net-next/c/4d66f235c790

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-07-28  0:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-26 14:31 [PATCH net-next] bridge: Remove unused declaration br_multicast_set_hash_max() YueHaibing
2023-07-27 11:29 ` Simon Horman
2023-07-27 11:44 ` Nikolay Aleksandrov
2023-07-28  0:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).